Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pack Windows application code into app.asar to improve startup and installation speed #1852

Closed
nanoant opened this issue Oct 10, 2018 · 1 comment

Comments

@nanoant
Copy link

nanoant commented Oct 10, 2018

This is my first issue report for Typora. First of all let me thank you for such a marvelous piece of software.

I would like to suggest to pack C:\Program Files\Typora\resources\app into app.asar, same as it is done with electron.asar. I expect this will make installation and application startup much faster since windows IO for 3,108 Files, 442 Folders (taken from installation stats) is a pity, especially if some antivirus is running in background.

More info on the subject:

  1. https://electronjs.org/docs/tutorial/application-distribution
  2. How to disable packing into asar files? electron-userland/electron-builder#428
@abnerlee
Copy link
Contributor

Packed some of it for quicker installation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants