Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve README #2

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Improve README #2

merged 1 commit into from
Dec 18, 2024

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Dec 14, 2024

[![PHP Version Require](https://img.shields.io/packagist/dependency-v/typisttech/php-matrix/php)]([https://github.com/typisttech/php-matrix/blob/readme/composer.json](https://github.com/typisttech/php-matrix/blob/main/composer.json))
[![PHP Version Require](https://img.shields.io/packagist/dependency-v/typisttech/php-matrix/php)](https://github.com/typisttech/php-matrix/blob/main/composer.json)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the badge.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When pasting an URL GitHub creates a link ...

Comment on lines -17 to -18
<br />
<br />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no more HTML4

maintained by [Tang Rufus](https://x.com/TangRufus), freelance developer for [hire](https://typist.tech/contact/).
maintained by [Tang Rufus](https://x.com/TangRufus), freelance developer [for hire](https://typist.tech/contact/).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"for hire" has the meaning

Full list of contributors can be found [here](https://github.com/typisttech/php-matrix/graphs/contributors).
Full list of contributors can be found [on GitHub](https://github.com/typisttech/php-matrix/graphs/contributors).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never link the word "here".

@tangrufus tangrufus added the documentation Improvements or additions to documentation label Dec 18, 2024
@tangrufus
Copy link
Member

Much better!

Thank you 👍

@tangrufus tangrufus merged commit 811c484 into typisttech:main Dec 18, 2024
@szepeviktor
Copy link
Contributor Author

Glad to contribute.

@szepeviktor szepeviktor deleted the patch-1 branch December 18, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Development

Successfully merging this pull request may close these issues.

2 participants