Throw error instead of using process.exit()#30
Open
BryanTorreblanca00 wants to merge 1 commit intotypicode:masterfrom
Open
Throw error instead of using process.exit()#30BryanTorreblanca00 wants to merge 1 commit intotypicode:masterfrom
BryanTorreblanca00 wants to merge 1 commit intotypicode:masterfrom
Conversation
BryanTorreblanca00
force-pushed
the
throw-error-instead
branch
from
a134d95 to
70a5ca9
Compare
BryanTorreblanca00
force-pushed
the
throw-error-instead
branch
from
70a5ca9 to
33d78a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 Hello first time contributor here,
This PR attempts to resolve #20 by throwing an error when a user needs to upgrade a node version. This will allow callers to gracefully handle the error and as mentioned in the issue, won't disrupt any asynchronous execution.
One thing to mention in this PR is we no longer check the error message in the tests, I'm unsure how to assert the error of
t.throws().Feedback appreciated! Thanks.