Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path error with basic example #420

Closed
blowsie opened this issue Nov 24, 2016 · 7 comments
Closed

path error with basic example #420

blowsie opened this issue Nov 24, 2016 · 7 comments

Comments

@blowsie
Copy link
Contributor

blowsie commented Nov 24, 2016

Hi, I tried to use the tool today and upon my first POST request the app crashes, every time.
I used the basic example, maybe there is a bug in the tool?

Windows 10


POST /posts 201 38.992 ms - 65
path.js:9
    throw new TypeError('Path must be a string. Received ' +
    ^

TypeError: Path must be a string. Received null

pathbug

@blowsie
Copy link
Contributor Author

blowsie commented Nov 24, 2016

I think the issue here was webstorm also running watches on the file

@blowsie blowsie closed this as completed Nov 24, 2016
@typicode
Copy link
Owner

Hi @blowsie,

On OS X it works so it may also be related to the OS.
Anyway I think watch events could be better handled in the code, especially if there's some error.

Thanks for the report :)

@blowsie
Copy link
Contributor Author

blowsie commented Nov 24, 2016

Doing a simple check if the file in the argument is null should prevent this issue

@typicode
Copy link
Owner

Yes, if (filename) { ... do you want to make a PR?

@blowsie
Copy link
Contributor Author

blowsie commented Nov 25, 2016

Can do, when i get time.

I stumbled across this today which would explain in a bit more detail why this happens.
https://webpack.github.io/docs/webpack-dev-server.html#working-with-editors-ides-supporting-safe-write

@typicode typicode reopened this Nov 27, 2016
@typicode
Copy link
Owner

Got some time, so I've added a check.

@typicode
Copy link
Owner

I've published v0.9.2 with the fix.
Let me know if it doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants