Merge branch 'master' into cfg-extend-once

Author: mernst

.coderabbit.yaml

@@ -0,0 +1,29 @@
+# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
+
+language: "en-US"
+
+reviews:
+  profile: "assertive"
+  high_level_summary: true
+  collapse_walkthrough: true
+  poem: false
+  review_status: false
+  path_filters:
+    - "!**/build/**"
+    - "!**/out/**"
+    - "!**/.gradle/**"
+    - "!**/.idea/**"
+    - "!**/node_modules/**"
+  ignore_title_keywords:
+    - "wip"
+    - "draft"
+
+chat:
+  art: false
+
+knowledge_base:
+  code_guidelines:
+    enabled: true
+    filePatterns:
+      - "**/.cursorrules"
+      - "**/CODING_STANDARDS.md"

docs/developer/new-contributor-projects.html

@@ -1899,7 +1899,7 @@ <h1 id="apply">How to apply to GSoC (relevant to GSoC students only)</h1>
  -->
 <!--  LocalWords:  unrefinement JavaParserUtil parseExpression StubParser
  -->
-<!--  LocalWords:  expressionWithParameterNames currentSourceVersion
+<!--  LocalWords:  expressionWithParameterNames currentSourceVersion '
  -->
 <!--  LocalWords:  AnnotationFileParser EnsuresCalledMethods CalledMethods
  -->

docs/developer/release/.flake8

@@ -448,7 +448,7 @@ <h3 id="file_layout">File Layout</h3>
           in interm are clones of the GitHub repositories.  This is so that
           we can test and push the release to the interm repositories then check the
           release before we have made any irreversible changes.  Then, when the release
-          is validated, all we do is run &quot;git push&quot; on all of the repos in interm.
+          is validated, all we do is run &quot;git push&quot; on all of the repositories in interm.
         </td>
       </tr>
       <tr>
@@ -738,7 +738,7 @@ <h4>Tasks:</h4> <!-- omit from toc -->
 </body>
 </html>
 
-<!--  LocalWords:  serif px pre CCC JDK AFS PAG mkdir cd svn co EFEFEF ul li Changelog stubparser JavaParser GenericAnnotatedTypeFactory CFTransfer CFAbstractTransfer CFAbstractAnalysis CFAnalysis CFAbstractStore CFStore CFAbstractValue CFValue BaseTypeVisitor BaseTypeChecker SourceChecker MultigraphQualifierHierarchy AbstractQualifierPolymorphism AnnotationUtils TreeAnnotator TODO typetools
+<!--  LocalWords:  serif px pre CCC JDK AFS PAG mkdir cd svn co EFEFEF ul li Changelog stubparser JavaParser GenericAnnotatedTypeFactory CFTransfer CFAbstractTransfer CFAbstractAnalysis CFAnalysis CFAbstractStore CFStore CFAbstractValue CFValue BaseTypeVisitor BaseTypeChecker SourceChecker MultigraphQualifierHierarchy AbstractQualifierPolymorphism AnnotationUtils TreeAnnotator TODO typetools SDK BOM includeGroup 'org checkerFrameworkVersion compileOnly testCompileOnly checkerFramework resolutionStrategy cacheChangingModulesFor tokenuser tokenkey
  -->
 <!--  LocalWords:  xml ver dev yyyyMMDD URL url diff buildfile kelloggm checkerframework gradle
  -->

docs/developer/release/README-release-process.html

@@ -20,6 +20,7 @@
 import javax.tools.DiagnosticCollector;
 import javax.tools.DiagnosticListener;
 import javax.tools.JavaFileObject;
+import org.checkerframework.javacutil.UserError;
 
 /**
  * This class contains static methods that parse Java code.
@@ -210,7 +211,14 @@ public static JavacParseResult<CompilationUnitTree> parseCompilationUnit(JavaFil
             new JavacFileManager(context, true, StandardCharsets.UTF_8)) {
 
       Log.instance(context).useSource(source);
-      ParserFactory parserFactory = ParserFactory.instance(context);
+      ParserFactory parserFactory;
+      try {
+        parserFactory = ParserFactory.instance(context);
+      } catch (IllegalAccessError e) {
+        throw new UserError(
+            "Provide `--add-exports=jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED` along with"
+                + " any other `--add-exports` in the Checker Framework invocation.");
+      }
       JavacParser parser = parserFactory.newParser(source.getCharContent(false), true, true, true);
       CompilationUnitTree cu = parser.parseCompilationUnit();
       ((JCCompilationUnit) cu).sourcefile = source;
@@ -244,7 +252,14 @@ public static JavacParseResult<ExpressionTree> parseExpression(JavaFileObject so
             new JavacFileManager(context, true, StandardCharsets.UTF_8)) {
 
       Log.instance(context).useSource(source);
-      ParserFactory parserFactory = ParserFactory.instance(context);
+      ParserFactory parserFactory;
+      try {
+        parserFactory = ParserFactory.instance(context);
+      } catch (IllegalAccessError e) {
+        throw new UserError(
+            "Provide `--add-exports=jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED` along with"
+                + " any other `--add-exports` in the Checker Framework invocation.");
+      }
       JavacParser parser = parserFactory.newParser(source.getCharContent(false), true, true, true);
       ExpressionTree eTree = parser.parseExpression();
       return new JavacParseResult<ExpressionTree>(eTree, diagnostics.getDiagnostics());
@@ -270,7 +285,14 @@ public static JavacParseResult<ExpressionTree> parseTypeUse(JavaFileObject sourc
             new JavacFileManager(context, true, StandardCharsets.UTF_8)) {
 
       Log.instance(context).useSource(source);
-      ParserFactory parserFactory = ParserFactory.instance(context);
+      ParserFactory parserFactory;
+      try {
+        parserFactory = ParserFactory.instance(context);
+      } catch (IllegalAccessError e) {
+        throw new UserError(
+            "Provide `--add-exports=jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED` along with"
+                + " any other `--add-exports` in the Checker Framework invocation.");
+      }
       JavacParser parser = parserFactory.newParser(source.getCharContent(false), true, true, true);
       ExpressionTree eTree = parser.parseType();
       return new JavacParseResult<ExpressionTree>(eTree, diagnostics.getDiagnostics());