Skip to content

docs: added TypeDI service decorator to example in README #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2021
Merged

docs: added TypeDI service decorator to example in README #643

merged 1 commit into from
Jan 19, 2021

Conversation

Leafgard
Copy link
Contributor

Description

Added service decorator to default DI controller example (TypeDI) as explained in issue

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

Doesn't fix #642 but helps to understand and prevent issue duplications

@Leafgard Leafgard changed the title #642 docs(readme): added service decorator to default DI controller e… docs(readme): added service decorator to default DI controller e… Jan 12, 2021
@NoNameProvided NoNameProvided changed the title docs(readme): added service decorator to default DI controller e… docs: added TypeDI service decorator to example in README Jan 19, 2021
@NoNameProvided NoNameProvided merged commit a8b5d35 into typestack:develop Jan 19, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

fix: TypeDI integration not working as expected on docs
2 participants