Routing-Controllers + class-validator bug?

[NoNameProvided]

From 11000100111000 in typestack/class-validator#128

When using the automatic validation from routing-controllers for some reason the email "patch@patch" is valid when we are using these validators and the "patch" validator group

@IsEmail({
        allow_display_name: false,
        allow_utf8_local_part: true,
        require_tld: true
    }, {
        groups: ["post", "patch", "login"]
    })
    @IsOptional({
        groups: ["patch"]
    })
    public email;

Doing it the manual way like so works however

let user = new UserValidation();
user.email = "patch@patch";
validate(user, {groups: ["patch"]}).then(console.log);

[dYale]

Having same issue. Validation isn't running implicitly in the controller.

[Benj0s]

I think I might be seeing similar issue too. Tried running a version of the auto validation based on the example in the README:

@JsonController()
class UserController {
    @Post('/login')
    login(@Body({validate: true}) user: User) {
        console.log('this is a valid body');
        return 'success!!!';
    }
}

class User {
    @IsEmail()
    email: string;

    @MinLength(6)
    password: string;
}

createExpressServer({
    controllers: [UserController]
}).listen(3000);

No matter what I send in the POST request I get a success back. Not sure if I've missed something in the above code but for the life of me I can't get it to validate and throw an error.

Validating manually through the class-validator does work though.

[MichalLytek]

The problem might not be in routing-controllers directly but with transformation of plain object to class instance using class-transformer.

[fredgate]

Exactly. I have similar issue. Parameters of my actions are custom classes (not interfaces) annotated with attributes like @minlength ... The problem is that parameters that I received are pure literal objects and not instances of my classes. So problem seems to be class-transformer.

I force options (that normally default to true) during creation of express server :

createExpressServer({
  controllers: [ MyController ],
  classTransformer: true,
  validation: true
});

[LogansUA]

Same for me.
So I have typeorm model

Group.ts

import { IsNotEmpty, IsUppercase, MaxLength } from 'class-validator';
import { Column, Entity, Index, OneToMany, PrimaryGeneratedColumn } from 'typeorm';
import { SubGroup } from './SubGroup';

@Entity({
    name: 'pss_groups',
})
export class Group {
    @PrimaryGeneratedColumn()
    public id: number;

    @Column({
        length: 1,
        name: 'name',
    })
    @Index({ unique: true })
    @IsNotEmpty()
    @MaxLength(1)
    @IsUppercase()
    public name: string;

    @Column({
        name: 'description',
    })
    public description: string;

    @OneToMany(type => SubGroup, subGroup => subGroup.group)
    public subGroups: SubGroup[];
}

And here's my controller

GroupController.ts

import { Body, HttpCode, JsonController, Post } from 'routing-controllers';
import { Service } from 'typedi';
import { Group } from '../models/Group';
import { GroupService } from '../services/GroupService';

@JsonController('/groups')
export class GroupController {
    constructor(@Service() private groupService: GroupService) {
    }

    @HttpCode(201)
    @Post('')
    public async createGroup(@Body({ required: true, validate: true }) group: Group): Promise<Group> {
        return this.groupService.createGroup(group);
    }
}

In result action is not validating data at all, even if I include validate function and use it on group value, the result will be an empty array.

My app initialization

app.ts

const expressApp = express();

expressApp.use(json({ limit: '50mb' }));
expressApp.use(urlencoded({ extended: true }));

useExpressServer(expressApp, {
    cors: true,
    routePrefix: env.app.routePrefix,
    defaultErrorHandler: false,
    classTransformer: true,
    validation: true,
    controllers: env.app.dirs.controllers,
    middlewares: env.app.dirs.middlewares,
});

Any thoughts?

[MardariG]

Any News about this issue?
I noticed that if using @controller works, if using @jsoncontroller not works.

The issue is caused because the version of class-validator that you have installed does not match the version of class-validator that routing-controllers is using. (see issue #424 and typestack/class-validator#166)

For a temporary fix you can run the following commands:

npm uninstall routing-controllers class-validator
npm install --save routing-controllers@0.7.7 class-validator@0.8.1

Edit: This will not work if you are using class-transformer. If you are using class-transformer read below for a solution

[MardariG]

I've tried your solution, still same issue, @Body is not validated.

[Nufflee]

@Andrew5569 Nope, doesn't work...

I created an example: https://github.com/Andrew5569/rc-body-validation

This is working for me

[Nufflee]

Yup, that works @Andrew5569 but I have basically the exact same setup but with controller and the model in a separate file and it just doesn't want to work.

[KwabenBerko]

@Andrew5569
Temporary fix works.
Cheers!

[nolazybits]

So I have done few test and this is what I found:

library	t1	t2	t3	t4	t5	t6	t7	t8	t9	t10
RC version	0.7.6	0.7.6	0.7.7	0.7.7	0.7.7	0.7.7	0.7.7	0.7.7	0.7.7	0.7.7
CV version	0.7.3	0.8.0-4	0.7.3	0.8.x	0.9.1	0.9.1	0.8.1	not in package.json	0.8.5	0.9.0
CT version	0.1.9	0.1.9	0.1.9	0.1.9	not in package.json	0.1.9	0.1.9	not in package.json	0.1.9	0.1.9
Working ?	✅	❌ normal as RC requires CV ^0.7.0	❌ normal as RC requires CV ^0.8.1	❌	✅	❌	❌	✅	✅	❌

So it seems to be a mix of class-validation / routing-controller changes breaking the validation, as the newer version of class-transformer works with routing-controller 0.7.6 and class-validator 0.7.3

@pleerock @NoNameProvided would you have any chance looking at this issue as it makes the stack (routing controller, class validator, class transfomers) non useable with latest version?

Thanks again 👍