Fix insufficient results during filtering.

kishorenc · kishorenc · commit 21de18ffabea · 2022-11-02T14:20:11.000+05:30
Very similar in nature to nmslib#344
diff --git a/hnswlib/hnswalg.h b/hnswlib/hnswalg.h
@@ -314,7 +314,8 @@ class HierarchicalNSW : public AlgorithmInterface<dist_t, filter_func_t> {
         while (!candidate_set.empty()) {
             std::pair<dist_t, tableint> current_node_pair = candidate_set.top();
 
-            if ((-current_node_pair.first) > lowerBound && (top_candidates.size() == ef || has_deletions == false)) {
+            if ((-current_node_pair.first) > lowerBound &&
+                (top_candidates.size() == ef || (is_filter_disabled && !has_deletions))) {
                 break;
             }
             candidate_set.pop();

Original file line number	Diff line number	Diff line change
`@@ -314,7 +314,8 @@ class HierarchicalNSW : public AlgorithmInterface<dist_t, filter_func_t> {`
`314`	`314`	`while (!candidate_set.empty()) {`
`315`	`315`	`std::pair<dist_t, tableint> current_node_pair = candidate_set.top();`
`316`	`316`
`317`		`- if ((-current_node_pair.first) > lowerBound && (top_candidates.size() == ef \|\| has_deletions == false)) {`
	`317`	`+ if ((-current_node_pair.first) > lowerBound &&`
	`318`	`+ (top_candidates.size() == ef \|\| (is_filter_disabled && !has_deletions))) {`
`318`	`319`	`break;`
`319`	`320`	`}`
`320`	`321`	`candidate_set.pop();`