This repository was archived by the owner on Sep 17, 2023. It is now read-only.
fix: improve error messages presented to the user #191
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves error messages presented to the user when encountering errors parsing JSON.
This required a bit of refactoring, since we were performing too much work up-front, and swallowing the helpful errors with a fallback (that stops looking for a lerna manifest and starts looking for an npm 7 workspace) that happened too late.
I took this opportunity to improve the representation of package.json manifests, which makes interaction with serde more ergonomic.
Here's an example of an error message when I remove the
version
property in a package.json file:cc @lifeiscontent