This repository was archived by the owner on Sep 17, 2023. It is now read-only.
feat: add support for M1 macOS #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit - compiles build artifacts with musl instead of glibc for greater compatibility - adds support for the following target triples - i686-unknown-linux-musl - aarch64-unknown-linux-musl - aarch64-apple-darwin
because the checkout action deletes the working directory
Instead of downloading the monorepo binary into the node_modules/.bin directory directly, provide a dummy script that `npm install` symlinks into that directly, and download the monorepo binary into the node_modules/@typescript-tools/rust-implementation/.bin directory, at the source of the symlink. Closes #115
- removes npm dependency on `tmp` - simplifies logic originally sourced from the esbuild install flow - favor a symlink over a hardlink to avoid the npm error referenced in the issue Closes #115
The intent of this commit is to remove the following warning available on install ``` Error: EEXIST: file already exists, symlink ... ``` Closes #115
This reverts commit 87bc2a5. This commit caused the error ``` npm ERR! code ENOENT npm ERR! syscall chmod npm ERR! path node_modules/@typescript-tools/rust-implementation/bin/monorepo npm ERR! errno -2 npm ERR! enoent ENOENT: no such file or directory, chmod 'node_modules/@typescript-tools/rust-implementation/bin/monorepo' npm ERR! enoent This is related to npm not being able to find a file. npm ERR! enoent ```
EricCrosson
commented
Mar 25, 2022
|
|
||
| Please try reinstalling "@typescript-tools/rust-implementation" or opening a ticket with | ||
| details about your use case. | ||
| EOF |
There was a problem hiding this comment.
Revert this diff
EricCrosson
force-pushed
the
beta
branch
5 times, most recently
from
0b8d111 to
1fa834a
Compare
bitgopatmcl
approved these changes
Mar 28, 2022
| @@ -1,3 +0,0 @@ | |||
| [target.x86_64-apple-darwin] | |||
| linker = "x86_64-apple-darwin14-clang" | |||
|
🎉 This PR is included in version 3.1.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add support for M1 macOS
Closes #33, closes #89, closes #101, closes #115