Skip to content
This repository was archived by the owner on Sep 17, 2023. It is now read-only.

Commit dfe9a58

Browse files
committed
fix(make-depends): always create internal npm deps directory
This commit adds an order-only prerequisite to the generated `<package>-docker-dependencies` make target, that of the `.internal-npm-dependencies` directory. Currently, the `.internal-npm-dependencies` directory is not created if there happen to be no use of internal dependencies, which means the Dockerfile commands ```dockerfile COPY my-package/.internal-npm-dependencies /tmp/internal-npm-dependencies ``` will not work in all cases (meaning for packages with dependencies and for those without). We add the order-only prerequisite so this `.internal-npm-dependencies` directory is always created, and this `COPY` command will always succeed.
1 parent 41e8d16 commit dfe9a58

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

templates/makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,5 +39,5 @@ dist/{{ scoped_package_name.trim_start_matches("@").replace("/", "-") }}.tgz: |
3939
ln $(firstword $|) $@
4040

4141
.PHONY: {{ unscoped_package_name }}-docker-dependencies
42-
{{ unscoped_package_name }}-docker-dependencies: $({{ unscoped_package_name.replace("-", "_").to_uppercase() }}_INTERNAL_NPM_DEPENDENCIES)
42+
{{ unscoped_package_name }}-docker-dependencies: $({{ unscoped_package_name.replace("-", "_").to_uppercase() }}_INTERNAL_NPM_DEPENDENCIES) | {{ package_directory }}/.internal-npm-dependencies
4343
{% endif %}

0 commit comments

Comments
 (0)