refactor: address PR feedback

Author: EricCrosson

Cargo.lock

@@ -12,7 +12,7 @@ anyhow = "1.0"
 askama = "0.11"
 clap = { version = "3.1.8", features = ["cargo", "derive"] }
 globwalk = "0.8.1"
-dpc-pariter = "0.5.1"
+pariter = "0.5.1"
 pathdiff = "0.2.1"
 serde = { version = "1.0", features = ["derive"] }
 serde_json = { version = "1.0", features = ["preserve_order"] }

Cargo.toml

@@ -1,7 +1,7 @@
 use std::collections::HashMap;
 use std::path::PathBuf;
 
-use anyhow::{anyhow, Result};
+use anyhow::{anyhow, ensure, Result};
 
 use pathdiff::diff_paths;
 
@@ -205,9 +205,10 @@ pub fn link_typescript_project_references(opts: opts::Link) -> Result<()> {
     let is_dependencies_link_success = link_package_dependencies(&opts, &lerna_manifest)
         .expect("Unable to link internal package dependencies");
 
-    if opts.check_only && !(is_children_link_success && is_dependencies_link_success) {
-        return Err(anyhow!("Found out-of-date project references"));
-    }
+    ensure!(
+        opts.check_only && !(is_children_link_success && is_dependencies_link_success),
+        "Found out-of-date project references"
+    );
 
     // TODO(7): create `tsconfig.settings.json` files
 

src/link.rs

@@ -1,6 +1,6 @@
 use std::collections::HashMap;
 
-use anyhow::{anyhow, Result};
+use anyhow::{ensure, Result};
 
 use crate::opts;
 
@@ -88,9 +88,6 @@ fn lint_dependency_version(opts: &opts::DependencyVersion) -> Result<()> {
         is_exit_success = false;
     }
 
-    if is_exit_success {
-        return Ok(());
-    } else {
-        return Err(anyhow!("Found unexpected dependency versions"));
-    }
+    ensure!(is_exit_success, "Found unexpected dependency versions");
+    Ok(())
 }

src/lint.rs

@@ -4,12 +4,7 @@ use anyhow::Result;
 
 use clap::Parser;
 
-use typescript_tools::link;
-use typescript_tools::lint;
-use typescript_tools::make_depend;
-use typescript_tools::opts;
-use typescript_tools::pin;
-use typescript_tools::query;
+use typescript_tools::{link, lint, make_depend, opts, pin, query};
 
 fn main() -> Result<()> {
     let opts = opts::Opts::parse();

src/main.rs

@@ -10,7 +10,7 @@ use globwalk::{FileType, GlobWalkerBuilder};
 
 use serde::{Deserialize, Serialize};
 
-use dpc_pariter::IteratorExt as _;
+use pariter::IteratorExt as _;
 
 use crate::configuration_file::ConfigurationFile;
 use crate::package_manifest::PackageManifest;
@@ -60,18 +60,21 @@ where
         .expect("Unable to create glob")
         .into_iter()
         .filter_map(Result::ok)
-        .parallel_map(move |dir_entry| {
-            PackageManifest::from_directory(
-                monorepo_root.clone(),
-                dir_entry
-                    .path()
-                    .parent()
-                    .expect("Unexpected package in monorepo root")
-                    .strip_prefix(monorepo_root.clone())
-                    .expect("Unexpected package in monorepo root")
-                    .to_owned(),
-            )
-        })
+        .parallel_map_custom(
+            |options| options.threads(32),
+            move |dir_entry| {
+                PackageManifest::from_directory(
+                    monorepo_root.clone(),
+                    dir_entry
+                        .path()
+                        .parent()
+                        .expect("Unexpected package in monorepo root")
+                        .strip_prefix(monorepo_root.clone())
+                        .expect("Unexpected package in monorepo root")
+                        .to_owned(),
+                )
+            },
+        )
         .collect()
 }