Skip to content

TS 4.0 labeled tuple elements 번역 #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 7, 2020

Conversation

guyeol
Copy link
Member

@guyeol guyeol commented Sep 2, 2020

PR전에 아래의 사항들을 확인하셨나요? 확인하셨다면, 체크해주세요!

  • CONTRIBUTING.md 파일을 정독했습니다.
  • lint 검사를 진행했습니다.
  • fetch를 통해 최신 upstream 내용을 반영했습니다.
👆 꼭 확인해주시길 바랍니다! 👆
  • PR의 종류가 무엇인지 체크해주세요!
  • Bug
  • Docs
  • Typo
  • etc.

PR에 대한 간단한 내용 설명을 부탁드립니다!

  • TypeScript 4.0 문서의 Labled Tuple Elements 부분 번역했습니다

@guyeol guyeol added the 🚀 번역중 번역을 진행하고 있어요 label Sep 2, 2020
@guyeol guyeol requested review from bumkeyy and dvlprsh September 2, 2020 09:12
@guyeol guyeol self-assigned this Sep 2, 2020
@guyeol guyeol removed the 🚀 번역중 번역을 진행하고 있어요 label Sep 2, 2020
Copy link
Member

@bumkeyy bumkeyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

guyeol and others added 6 commits September 7, 2020 10:34
Co-authored-by: Kibeom Kwon <kgbum2222@gmail.com>
Co-authored-by: Seohee Park <dvlprsh103@gmail.com>
Co-authored-by: Seohee Park <dvlprsh103@gmail.com>
Co-authored-by: Seohee Park <dvlprsh103@gmail.com>
Co-authored-by: Seohee Park <dvlprsh103@gmail.com>
Co-authored-by: Seohee Park <dvlprsh103@gmail.com>
Copy link
Member

@dvlprsh dvlprsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dvlprsh dvlprsh merged commit 89a7977 into master Sep 7, 2020
@bumkeyy bumkeyy deleted the issue171/labeled-tuple-elements branch November 8, 2020 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants