Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): disallow errorOnTypeScriptSyntacticAndSemanticIssues #8784

Conversation

peanutenthusiast
Copy link
Contributor

PR Checklist

Overview

This PR overrides the above property to false in parseForESLint and adds, modifies relevant test cases.

Continuation of #8684

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @peanutenthusiast!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit afcca53
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66045e115f383700087854a1
😎 Deploy Preview https://deploy-preview-8784--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98
Accessibility: 100
Best Practices: 92
SEO: 98
PWA: 80
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@peanutenthusiast peanutenthusiast changed the title Ban errorOnTypeScriptSyntacticAndSemanticIssues from user consumption fix(parser): prevent errorOnTypeScriptSyntacticAndSemanticIssues from user consumption Mar 27, 2024
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks for this!

@bradzacher bradzacher changed the title fix(parser): prevent errorOnTypeScriptSyntacticAndSemanticIssues from user consumption fix(parser): disallow errorOnTypeScriptSyntacticAndSemanticIssues Mar 28, 2024
@bradzacher bradzacher merged commit d5615d7 into typescript-eslint:main Mar 28, 2024
63 of 64 checks passed
yeonjuan pushed a commit to yeonjuan/typescript-eslint that referenced this pull request Mar 31, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ban errorOnTypeScriptSyntacticAndSemanticIssues from being used within parser
2 participants