-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(parser): disallow errorOnTypeScriptSyntacticAndSemanticIssues
#8784
fix(parser): disallow errorOnTypeScriptSyntacticAndSemanticIssues
#8784
Conversation
…false and add, modify relevant tests respectively
Thanks for the PR, @peanutenthusiast! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Thanks for this!
errorOnTypeScriptSyntacticAndSemanticIssues
PR Checklist
errorOnTypeScriptSyntacticAndSemanticIssues
from being used withinparser
#8681Overview
This PR overrides the above property to false in
parseForESLint
and adds, modifies relevant test cases.Continuation of #8684