feat(utils): add parser name to thrown parser error message

[disaacson]

PR Checklist

• Addresses an existing open issue: fixes Feature: Improve error message reported by getParserServices #8482
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

An error is thrown if there is an issue with the detected parser. This change adds information on the parser that is causing the error to be thrown.

Current message:

Error: Error while loading rule '@typescript-eslint/no-base-to-string': You have used a rule which requires parserServices to be generated. You must therefore provide a value for the "parserOptions.project" property for @typescript-eslint/parser.
Note: detected a parser other than @typescript-eslint/parser. Make sure the parser is configured to forward

This change adds the following detail to the error message:
Parser: <detected parser causing the error>

[typescript-eslint]

Thanks for the PR, @disaacson!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	cee264e
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/65f4f603c96b250008a0067d
😎 Deploy Preview	https://deploy-preview-8484--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (🟢 up 6 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[disaacson]

Apologies. Let me squash the commits.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit cee264e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 32 targets

• nx test eslint-plugin
• nx test type-utils
• nx test utils
• nx run types:build
• nx test visitor-keys
• nx test typescript-eslint
• nx run repo-tools:postinstall-script
• nx test typescript-estree
• nx test eslint-plugin --coverage=false
• nx test rule-schema-to-typescript-types
• nx test scope-manager
• nx test repo-tools
• nx test parser
• nx test ast-spec
• nx test eslint-plugin-internal
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint
• nx test typescript-eslint --coverage=false
• nx test visitor-keys --coverage=false
• nx test utils --coverage=false
• nx test rule-schema-to-typescript-types --coverage=false
• nx test type-utils --coverage=false
• nx test typescript-estree --coverage=false
• nx test repo-tools --coverage=false
• nx test scope-manager --coverage=false
• nx test eslint-plugin-internal --coverage=false
• nx test parser --coverage=false
• nx run-many --target=lint --parallel --exclude eslint-plugin
• nx test ast-spec --coverage=false
• nx run-many --target=typecheck --parallel
• nx run repo-tools:generate-configs
• nx run integration-tests:test
• nx run repo-tools:apply-canary-version

---

Sent with 💌 from NxCloud.

[JoshuaKGoldberg]

@disaacson no need to rebase or squash 🙂. We prefer the raw, unedited history. https://typescript-eslint.io/contributing/pull-requests

[disaacson]

Using the example in the automated test for that error, it would now output

You have used a rule which requires parserServices to be generated. You must therefore provide a value for the \"parserOptions.project\" property for @typescript-eslint/parser.
    Parser: @babel/parser.js
    Note: detected a parser other than @typescript-eslint/parser. Make sure the parser is configured to forward \"parserOptions.project\" to @typescript-eslint/parser.

The information that the parser it found was @babel/parser.js can help track down the cause of the error.
If you think it would be better, I could change the PR to only include that information if the second Note error is thrown.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.13%. Comparing base (609a000) to head (d0350ae).
Report is 2 commits behind head on main.

❗ Current head d0350ae differs from pull request most recent head cee264e. Consider uploading reports for the commit cee264e to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8484      +/-   ##
==========================================
- Coverage   87.23%   87.13%   -0.10%     
==========================================
  Files         251      251              
  Lines       12319    12270      -49     
  Branches     3884     3868      -16     
==========================================
- Hits        10746    10691      -55     
- Misses       1303     1307       +4     
- Partials      270      272       +2     

Flag	Coverage Δ
unittest	87.13% <100.00%> (-0.10%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...ckages/utils/src/eslint-utils/getParserServices.ts	93.75% <100.00%> (+0.89%)	⬆️

... and 65 files with indirect coverage changes

[JoshuaKGoldberg]

LGTM, thanks! 🙌

Will wait for @bradzacher a bit as Brad was also commenting on the issue.

[disaacson]

I looked into the failed check for yarn lint. It passes locally on my machine. Also, the error appears to be related to a lock (see below). I wonder if rerunning the check will work. From what I read, it requires someone with write permissions on the repo to rerun the check. Or, I could trigger one by pushing an empty commit.

I'll leave it alone for now, but let me know if you'd like me to trigger it with an empty commit.

Error in check:

❌ > nx run typescript-eslint:lint
  
  
  Linting "typescript-eslint"...
  
   >  NX   _
  
  
  AtomicsWaitError: _
      at _Lock.lock (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/make-synchronized/index.cjs:128:11)
      at request (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/make-synchronized/index.cjs:161:8)
      at #sendActionToWorker (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/make-synchronized/index.cjs:218:61)
      at ThreadsWorker.sendAction (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/make-synchronized/index.cjs:177:36)
      at /home/runner/work/typescript-eslint/typescript-eslint/node_modules/make-synchronized/index.cjs:273:26
      at cacheResult (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/make-synchronized/index.cjs:242:25)
      at cachePathResult (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/make-synchronized/index.cjs:246:52)
      at _Synchronizer.getInformation (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/make-synchronized/index.cjs:270:12)
      at _Synchronizer.get (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/make-synchronized/index.cjs:277:30)
      at Module.get [as resolveConfig] (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/make-synchronized/index.cjs:350:29)
      ```

[auvred]

Looks great! 🔥

---

CI failures are not related to this PR. See #8373

[disaacson]

Is there anything else you'd like me to change @bradzacher or @JoshuaKGoldberg?

[auvred]

@disaacson, As per our contributing guidelines this PR is in the queue of PRs to reviewed, and will be reviewed when we are able.

This project is run by volunteer maintainers, so it might be a bit before we can find the time to get to it.

[bradzacher]