fix(scope-manager): exclude Program from DefinitionBase node types #11469

dbarabashh · 2025-08-08T13:35:54Z

PR Checklist

Addresses an existing open issue: fixes Bug: DefinitionBase shouldn't allow its Node type to be TSESTree.Program #11334
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

This PR improves type safety in the scope-manager package by preventing TSESTree.Program nodes from being used as definition nodes.

typescript-eslint · 2025-08-08T13:35:57Z

Thanks for the PR, @dbarabashh!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2025-08-08T13:36:00Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`382a149`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/68b0b4fce94a83000803763e
😎 Deploy Preview	https://deploy-preview-11469--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 77 (🔴 down 20 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

nx-cloud · 2025-08-08T13:37:10Z

View your CI Pipeline Execution ↗ for commit 382a149

Command	Status	Duration	Result
`nx test eslint-plugin --coverage=false`	✅ Succeeded	5m 16s	View ↗
`nx run-many -t lint`	✅ Succeeded	3m 13s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	2m 22s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	21s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	9s	View ↗
`nx run integration-tests:test`	✅ Succeeded	6s	View ↗
`nx run types:build`	✅ Succeeded	5s	View ↗
`nx run generate-configs`	✅ Succeeded	9s	View ↗
`Additional runs (27)`	✅ Succeeded	...	View ↗

☁️ Nx Cloud last updated this comment at 2025-08-28 20:11:12 UTC

dbarabashh · 2025-08-08T13:59:36Z

I am not sure that the linter failed now exactly because of my changes, because locally this command was successful

JoshuaKGoldberg · 2025-08-08T15:59:09Z

Try a yarn build first, then a yarn lint? It looks like the types are better informed because of this change (nice!), so lint rules are pointing out previously missed unnecessary ?.s and the like.

codecov · 2025-08-09T22:58:15Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.87%. Comparing base (31a7336) to head (382a149).
⚠️ Report is 28 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11469      +/-   ##
==========================================
- Coverage   90.87%   90.87%   -0.01%     
==========================================
  Files         505      505              
  Lines       51146    51143       -3     
  Branches     8424     8424              
==========================================
- Hits        46480    46477       -3     
  Misses       4652     4652              
  Partials       14       14

Flag	Coverage Δ
unittest	`90.87% <100.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...t-plugin/src/rules/no-confusing-void-expression.ts	`100.00% <100.00%> (ø)`
...s/eslint-plugin/src/util/collectUnusedVariables.ts	`96.19% <100.00%> (ø)`
...ges/scope-manager/src/definition/DefinitionBase.ts	`100.00% <ø> (ø)`
...src/definition/ImplicitGlobalVariableDefinition.ts	`100.00% <ø> (ø)`
packages/scope-manager/src/referencer/Reference.ts	`93.44% <ø> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dbarabashh · 2025-08-09T22:58:44Z

@JoshuaKGoldberg thank you, done

kirkwaiblinger · 2025-08-27T17:58:52Z

@dbarabashh Would you mind also auditing for uses of nullThrows that can be removed? For example,

typescript-eslint/packages/eslint-plugin/src/rules/no-confusing-void-expression.ts

Line 368 in 63ab002

const block = nullThrows(node.parent, NullThrowsReasons.MissingParent);

JoshuaKGoldberg

+1 to what Kirk said. I also think the new type is good enough that it should be moved to @typescript-eslint/types altogether. Thanks for starting this! 🙌

packages/scope-manager/src/definition/DefinitionBase.ts

JoshuaKGoldberg

🤤 look at all those removed ?~s and nullThrows()`s! Absolutely lovely. Thanks!

kirkwaiblinger

🎉🎉

@dbarabashh

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.42.0 | 8.43.0 | | npm | @typescript-eslint/parser | 8.42.0 | 8.43.0 | ## [v8.43.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8430-2025-09-08) ##### 🚀 Features - **typescript-estree:** disallow empty type parameter/argument lists ([#11563](typescript-eslint/typescript-eslint#11563)) ##### 🩹 Fixes - **eslint-plugin:** \[prefer-return-this-type] don't report an error when returning a union type that includes a classType ([#11432](typescript-eslint/typescript-eslint#11432)) - **eslint-plugin:** \[no-deprecated] should report deprecated exports and reexports ([#11359](typescript-eslint/typescript-eslint#11359)) - **eslint-plugin:** \[no-floating-promises] allowForKnownSafeCalls now supports function names ([#11423](typescript-eslint/typescript-eslint#11423), [#11430](typescript-eslint/typescript-eslint#11430)) - **eslint-plugin:** \[consistent-type-exports] fix declaration shadowing ([#11457](typescript-eslint/typescript-eslint#11457)) - **eslint-plugin:** \[no-unnecessary-type-conversion] only report \~\~ on integer literal types ([#11517](typescript-eslint/typescript-eslint#11517)) - **scope-manager:** exclude Program from DefinitionBase node types ([#11469](typescript-eslint/typescript-eslint#11469)) - **eslint-plugin:** \[no-non-null-assertion] do not suggest optional chain on LHS of assignment ([#11489](typescript-eslint/typescript-eslint#11489)) - **type-utils:** add union type support to TypeOrValueSpecifier ([#11526](typescript-eslint/typescript-eslint#11526)) ##### ❤️ Thank You - Dima [@dbarabashh](https://github.com/dbarabashh) - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - mdm317 - tao - Victor Genaev [@mainframev](https://github.com/mainframev) - Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw) - 민감자(Minji Kim) [@mouse0429](https://github.com/mouse0429) - 송재욱 You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.

fix: exclude Program from DefinitionBase node types

2d08593

fix eslint

5dd757a

dbarabashh mentioned this pull request Aug 23, 2025

fix(rule-tester): normalize paths before checking if they escape cwd #11525

Merged

3 tasks

Merge branch 'main' into fix/scope-manager-node-parent-type-safety

308ac8b

JoshuaKGoldberg requested changes Aug 27, 2025

View reviewed changes

packages/scope-manager/src/definition/DefinitionBase.ts Outdated Show resolved Hide resolved

JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Aug 27, 2025

Add NodeWithParent type

382a149

dbarabashh requested a review from JoshuaKGoldberg August 28, 2025 20:11

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Aug 28, 2025

JoshuaKGoldberg approved these changes Sep 3, 2025

View reviewed changes

JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Sep 3, 2025

kirkwaiblinger approved these changes Sep 3, 2025

View reviewed changes

JoshuaKGoldberg merged commit c068a4f into typescript-eslint:main Sep 3, 2025
65 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(scope-manager): exclude Program from DefinitionBase node types #11469

fix(scope-manager): exclude Program from DefinitionBase node types #11469

Uh oh!

dbarabashh commented Aug 8, 2025 •

edited

Loading

Uh oh!

typescript-eslint bot commented Aug 8, 2025

Uh oh!

netlify bot commented Aug 8, 2025 •

edited

Loading

Uh oh!

nx-cloud bot commented Aug 8, 2025 •

edited

Loading

Uh oh!

dbarabashh commented Aug 8, 2025

Uh oh!

JoshuaKGoldberg commented Aug 8, 2025

Uh oh!

codecov bot commented Aug 9, 2025 •

edited

Loading

Uh oh!

dbarabashh commented Aug 9, 2025

Uh oh!

kirkwaiblinger commented Aug 27, 2025

Uh oh!

JoshuaKGoldberg left a comment

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Uh oh!

kirkwaiblinger left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fix(scope-manager): exclude Program from DefinitionBase node types #11469

fix(scope-manager): exclude Program from DefinitionBase node types #11469

Uh oh!

Conversation

dbarabashh commented Aug 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslint bot commented Aug 8, 2025

Uh oh!

netlify bot commented Aug 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for typescript-eslint ready!

Uh oh!

nx-cloud bot commented Aug 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dbarabashh commented Aug 8, 2025

Uh oh!

JoshuaKGoldberg commented Aug 8, 2025

Uh oh!

codecov bot commented Aug 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dbarabashh commented Aug 9, 2025

Uh oh!

kirkwaiblinger commented Aug 27, 2025

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

kirkwaiblinger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dbarabashh commented Aug 8, 2025 •

edited

Loading

netlify bot commented Aug 8, 2025 •

edited

Loading

nx-cloud bot commented Aug 8, 2025 •

edited

Loading

codecov bot commented Aug 9, 2025 •

edited

Loading