Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-unnecessary-condition] better message when comparing between literal types #10454

Merged
merged 4 commits into from
Dec 14, 2024

Conversation

kirkwaiblinger
Copy link
Member

@kirkwaiblinger kirkwaiblinger commented Dec 5, 2024

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 3d1186a
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/675dc61dd963020008b414f5
😎 Deploy Preview https://deploy-preview-10454--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Dec 5, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3d1186a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.78%. Comparing base (eaae68c) to head (3d1186a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10454   +/-   ##
=======================================
  Coverage   86.78%   86.78%           
=======================================
  Files         445      445           
  Lines       15365    15365           
  Branches     4475     4475           
=======================================
  Hits        13335    13335           
  Misses       1675     1675           
  Partials      355      355           
Flag Coverage Δ
unittest 86.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...slint-plugin/src/rules/no-unnecessary-condition.ts 99.20% <ø> (ø)

@kirkwaiblinger kirkwaiblinger marked this pull request as ready for review December 6, 2024 17:45
@kirkwaiblinger kirkwaiblinger changed the title fix(eslint-plugin): [no-unnecessary-condition] better boolean literal compare message fix(eslint-plugin): [no-unnecessary-condition] better message when comparing between literal types Dec 6, 2024
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awkward seal meme. Caption: "SEAL OF APPROVAL"

I'd like to merge this before our Monday release. @kirkwaiblinger if you want to switch it over before then, feel free to do it and merge yourself (or if you're in a rush, just ping me and I can).

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Dec 14, 2024
@kirkwaiblinger
Copy link
Member Author

should be good to merge now 👍

@github-actions github-actions bot removed the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Dec 14, 2024
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 334d025 into typescript-eslint:main Dec 14, 2024
63 checks passed
@kirkwaiblinger kirkwaiblinger deleted the nuc branch December 15, 2024 01:29
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Dec 16, 2024
##### [v8.18.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8181-2024-12-16)

##### 🩹 Fixes

-   **scope-manager:** visit params decorator before nest scope ([#10475](typescript-eslint/typescript-eslint#10475))
-   **eslint-plugin:** \[no-unnecessary-condition] better message when comparing between literal types ([#10454](typescript-eslint/typescript-eslint#10454))
-   **eslint-plugin:** use consistent naming for asserting types and casting values ([#10472](typescript-eslint/typescript-eslint#10472))
-   **eslint-plugin:** \[no-unnecessary-boolean-literal-compare] flag values of a type parameter with boolean type constraints ([#10474](typescript-eslint/typescript-eslint#10474))
-   **eslint-plugin:** handle string like index type ([#10460](typescript-eslint/typescript-eslint#10460))
-   **eslint-plugin:** \[no-unnecessary-template-expression] don't report when an expression includes comment ([#10444](typescript-eslint/typescript-eslint#10444))

##### ❤️ Thank You

-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)
-   Ronen Amiel
-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Dec 16, 2024
| datasource | package                          | from   | to     |
| ---------- | -------------------------------- | ------ | ------ |
| npm        | @typescript-eslint/eslint-plugin | 8.18.0 | 8.18.1 |
| npm        | @typescript-eslint/parser        | 8.18.0 | 8.18.1 |


## [v8.18.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8181-2024-12-16)

##### 🩹 Fixes

-   **scope-manager:** visit params decorator before nest scope ([#10475](typescript-eslint/typescript-eslint#10475))
-   **eslint-plugin:** \[no-unnecessary-condition] better message when comparing between literal types ([#10454](typescript-eslint/typescript-eslint#10454))
-   **eslint-plugin:** use consistent naming for asserting types and casting values ([#10472](typescript-eslint/typescript-eslint#10472))
-   **eslint-plugin:** \[no-unnecessary-boolean-literal-compare] flag values of a type parameter with boolean type constraints ([#10474](typescript-eslint/typescript-eslint#10474))
-   **eslint-plugin:** handle string like index type ([#10460](typescript-eslint/typescript-eslint#10460))
-   **eslint-plugin:** \[no-unnecessary-template-expression] don't report when an expression includes comment ([#10444](typescript-eslint/typescript-eslint#10444))

##### ❤️ Thank You

-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)
-   Ronen Amiel
-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants