chore: fix issues introduced by updated nx configuration (#11230)

Author: aryaemami59

.prettierignore

@@ -34,8 +34,5 @@ CHANGELOG.md
 packages/website/.docusaurus
 packages/website/build
 
-# see the file header in eslint-base.test.js for more info
-packages/rule-tester/tests/eslint-base
-
 /.nx/cache
 /.nx/workspace-data

eslint.config.mjs

@@ -83,8 +83,6 @@ export default tseslint.config(
       'packages/types/src/generated/**/*.ts',
       // Playground types downloaded from the web
       'packages/website/src/vendor/',
-      // see the file header in eslint-base.test.js for more info
-      'packages/rule-tester/tests/eslint-base/',
     ],
     name: 'global-ignores',
   },

knip.ts

@@ -54,35 +54,40 @@ export default {
         ],
       },
     },
+
     'packages/eslint-plugin': {
-      entry: ['tools/**'],
-      ignore: [
-        'tests/fixtures/**',
-        'typings/eslint-rules.d.ts',
-        'typings/typescript.d.ts',
-      ],
-      ignoreDependencies: ['tsx'], // used in nx target definitions
+      ignore: ['typings/eslint-rules.d.ts', 'typings/typescript.d.ts'],
+
+      project: ['src/**/*.ts!', 'tools/**/*.mts'],
+
+      vitest: {
+        config: ['vitest.config.mts'],
+        entry: ['tests/**/*.{bench,test,test-d}.?(c|m)ts?(x)'],
+        project: ['tests/**', '!tests/fixtures/**'],
+      },
     },
+
     'packages/eslint-plugin-internal': {
       ignore: ['tests/fixtures/**'],
     },
     'packages/integration-tests': {
       ignore: ['fixtures/**'],
     },
-    'packages/parser': {
-      ignore: ['tests/fixtures/**'],
 
+    'packages/parser': {
       vitest: {
         config: ['vitest.config.mts'],
-        entry: ['tests/lib/**/*.{bench,test,test-d}.?(c|m)ts?(x)'],
+        entry: [
+          'tests/lib/**/*.{bench,test,test-d}.?(c|m)ts?(x)',
+          'tests/test-utils/test-utils.ts',
+          'tests/test-utils/ts-error-serializer.ts',
+        ],
+        project: ['tests/**', '!tests/fixtures/**'],
       },
     },
+
     'packages/rule-tester': {
       ignore: ['typings/eslint.d.ts'],
-
-      mocha: {
-        entry: ['tests/eslint-base/eslint-base.test.js'],
-      },
     },
     'packages/scope-manager': {
       ignore: ['tests/fixtures/**'],
@@ -109,6 +114,15 @@ export default {
         ],
       },
     },
+
+    'packages/types': {
+      project: [
+        'src/**/*.ts!',
+        '!src/generated/**/*.ts',
+        'tools/copy-ast-spec.mts',
+      ],
+    },
+
     'packages/typescript-estree': {
       entry: ['src/use-at-your-own-risk.ts'],
       ignore: ['tests/fixtures/**', 'typings/typescript.d.ts'],

nx.json

@@ -19,14 +19,8 @@
       "plugin": "@nx/vite/plugin",
       "exclude": ["*"],
       "options": {
-        "testTargetName": "test"
-      }
-    },
-    {
-      "plugin": "@nx/eslint/plugin",
-      "include": ["packages/*"],
-      "options": {
-        "targetName": "lint"
+        "testTargetName": "test",
+        "typecheckTargetName": "vite:typecheck"
       }
     }
   ],
@@ -51,7 +45,20 @@
     }
   },
   "targetDefaults": {
+    "lint": {
+      "cache": false,
+      "dependsOn": ["eslint-plugin-internal:build", "typescript-eslint:build"],
+      "options": {
+        "cwd": "{workspaceRoot}",
+        "config": "{workspaceRoot}/eslint.config.mjs",
+        "args": ["{projectRoot}"]
+      }
+    },
     "test": {
+      "dependsOn": ["^build"],
+      "options": {
+        "config": "vitest.config.mts"
+      },
       "outputs": ["{projectRoot}/coverage"]
     }
   },

package.json

@@ -55,7 +55,6 @@
     "@eslint/eslintrc": "^3.2.0",
     "@eslint/js": "^9.26.0",
     "@nx/devkit": "21.0.3",
-    "@nx/eslint": "21.0.3",
     "@nx/js": "21.0.3",
     "@nx/vite": "21.0.3",
     "@nx/workspace": "21.0.3",
@@ -149,11 +148,11 @@
         "cache": true
       },
       "lint": {
-        "command": "eslint . --ignore-pattern=packages --cache",
-        "dependsOn": [
-          "typescript-eslint:build",
-          "eslint-plugin-internal:build"
-        ],
+        "command": "eslint",
+        "options": {
+          "cache": true,
+          "ignore-pattern": "packages"
+        },
         "cache": false
       },
       "clean": {

packages/ast-spec/package.json

@@ -31,7 +31,6 @@
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "scripts": {
-    "//": "These package scripts are mostly here for convenience. Task running is handled by Nx at the root level.",
     "build": "yarn run -BT nx build",
     "clean": "rimraf dist/ coverage/",
     "clean-fixtures": "rimraf -g \"./src/**/fixtures/**/snapshots\"",
@@ -82,7 +81,14 @@
         ],
         "cache": true
       },
+      "lint": {
+        "command": "eslint"
+      },
       "typecheck": {
+        "outputs": [
+          "{workspaceRoot}/dist",
+          "{projectRoot}/dist"
+        ],
         "dependsOn": [
           "typescript-estree:build"
         ]

packages/ast-spec/tests/util/serialize-error.ts

@@ -1,4 +1,5 @@
 import type { ParseError as BabelParseError } from '@babel/parser';
+
 import { codeFrameColumns } from '@babel/code-frame';
 
 import { TSError } from './parsers/typescript-estree-import';

packages/ast-spec/vitest.config.mts

@@ -19,6 +19,11 @@ const vitestConfig = mergeConfig(
         './tests/util/setupVitest.mts',
         './tests/util/custom-matchers/custom-matchers.ts',
       ],
+
+      typecheck: {
+        enabled: true,
+        tsconfig: path.join(import.meta.dirname, 'tsconfig.spec.json'),
+      },
     },
   }),
 );

packages/eslint-plugin-internal/package.json

@@ -14,7 +14,6 @@
   "homepage": "https://typescript-eslint.io",
   "license": "MIT",
   "scripts": {
-    "//": "These package scripts are mostly here for convenience. Task running is handled by Nx at the root level.",
     "build": "yarn run -BT nx build",
     "clean": "rimraf dist/ coverage/",
     "format": "yarn run -T format",
@@ -28,17 +27,23 @@
     "@typescript-eslint/scope-manager": "workspace:*",
     "@typescript-eslint/type-utils": "workspace:*",
     "@typescript-eslint/utils": "workspace:*",
-    "prettier": "^3.2.5"
+    "prettier": "3.5.0"
   },
   "devDependencies": {
     "@vitest/coverage-v8": "^3.1.3",
+    "eslint": "*",
     "rimraf": "*",
     "vitest": "^3.1.3"
   },
   "nx": {
     "name": "eslint-plugin-internal",
     "includedScripts": [
       "clean"
-    ]
+    ],
+    "targets": {
+      "lint": {
+        "command": "eslint"
+      }
+    }
   }
 }

packages/eslint-plugin/package.json

@@ -48,12 +48,11 @@
     "typescript"
   ],
   "scripts": {
-    "//": "These package scripts are mostly here for convenience. Task running is handled by Nx at the root level.",
     "build": "yarn run -BT nx build",
     "clean": "rimraf dist/ coverage/",
     "format": "yarn run -T format",
     "generate-breaking-changes": "yarn run -BT nx generate-breaking-changes",
-    "generate-configs": "yarn run -T generate-configs",
+    "generate-configs": "yarn run -BT nx generate-configs repo",
     "lint": "yarn run -BT nx lint",
     "test": "yarn run -BT nx test",
     "typecheck": "yarn run -BT nx typecheck"
@@ -84,6 +83,7 @@
     "mdast-util-from-markdown": "^2.0.0",
     "mdast-util-mdx": "^3.0.0",
     "micromark-extension-mdxjs": "^3.0.0",
+    "prettier": "3.5.0",
     "rimraf": "*",
     "title-case": "^4.0.0",
     "tsx": "*",
@@ -114,6 +114,9 @@
         "dependsOn": [
           "type-utils:build"
         ]
+      },
+      "lint": {
+        "command": "eslint"
       }
     }
   }