feat(eslint-plugin): [no-this-alias] report on assignment expressions (#4718)

Author: juank1809

packages/eslint-plugin/src/rules/no-this-alias.ts

@@ -48,11 +48,11 @@ export default util.createRule<Options, MessageIds>({
   ],
   create(context, [{ allowDestructuring, allowedNames }]) {
     return {
-      "VariableDeclarator[init.type='ThisExpression']"(
-        node: TSESTree.VariableDeclarator,
+      "VariableDeclarator[init.type='ThisExpression'], AssignmentExpression[right.type='ThisExpression']"(
+        node: TSESTree.VariableDeclarator | TSESTree.AssignmentExpression,
       ): void {
-        const { id } = node;
-
+        const id =
+          node.type === AST_NODE_TYPES.VariableDeclarator ? node.id : node.left;
         if (allowDestructuring && id.type !== AST_NODE_TYPES.Identifier) {
           return;
         }

packages/eslint-plugin/tests/rules/no-this-alias.test.ts

@@ -66,6 +66,13 @@ declare module 'foo' {
       code: 'const self = this;',
       errors: [idError],
     },
+    {
+      code: `
+let that;
+that = this;
+      `,
+      errors: [idError],
+    },
     {
       code: 'const { props, state } = this;',
       options: [