Skip to content

Added jsx-boolean-value converter #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/rules/converters/eslint-plugin-react/jsx-boolean-value.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import { RuleConverter } from "../../converter";

export const convertJsxBooleanValue: RuleConverter = (tslintRule) => {
return {
rules: [
{
...(tslintRule.ruleArguments.length !== 0 && {
ruleArguments: tslintRule.ruleArguments,
}),
ruleName: "react/jsx-boolean-value",
},
],
plugins: ["eslint-plugin-react"],
};
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
import { convertJsxBooleanValue } from "../jsx-boolean-value";

describe(convertJsxBooleanValue, () => {
test("conversion without arguments", () => {
const result = convertJsxBooleanValue({
ruleArguments: [],
});

expect(result).toEqual({
rules: [
{
ruleName: "react/jsx-boolean-value",
},
],
plugins: ["eslint-plugin-react"],
});
});

test("conversion with arguments", () => {
const alwaysResult = convertJsxBooleanValue({
ruleArguments: ["always"],
});
const neverResult = convertJsxBooleanValue({
ruleArguments: ["never"],
});

expect(alwaysResult).toEqual({
rules: [
{
ruleArguments: ["always"],
ruleName: "react/jsx-boolean-value",
},
],
plugins: ["eslint-plugin-react"],
});
expect(neverResult).toEqual({
rules: [
{
ruleArguments: ["never"],
ruleName: "react/jsx-boolean-value",
},
],
plugins: ["eslint-plugin-react"],
});
});
});
4 changes: 4 additions & 0 deletions src/rules/rulesConverters.ts
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,9 @@ import { convertUseLifecycleInterface } from "./converters/codelyzer/use-lifecyc
import { convertUsePipeDecorator } from "./converters/codelyzer/use-pipe-decorator";
import { convertUsePipeTransformInterface } from "./converters/codelyzer/use-pipe-transform-interface";

// ESLint-React converters
import { convertJsxBooleanValue } from "./converters/eslint-plugin-react/jsx-boolean-value";

/**
* Keys TSLint rule names to their ESLint rule converters.
*/
Expand Down Expand Up @@ -208,6 +211,7 @@ export const rulesConverters = new Map([
["interface-name", convertInterfaceName],
["interface-over-type-literal", convertInterfaceOverTypeLiteral],
["jsdoc-format", convertJSDocFormat],
["jsx-boolean-value", convertJsxBooleanValue],
["label-position", convertLabelPosition],
["linebreak-style", convertLinebreakStyle],
["max-classes-per-file", convertMaxClassesPerFile],
Expand Down