Fixed crash when ESLint rule has multiple rule arguments #586
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prs
Overview
I could only reproduce #581's crash for an existing
.eslintrc.js
containing a rule specifying multiple arguments:The root issue was that
normalizeESLintRules
was converting the raw rules into an object with a single value inruleArguments
, not an array:If
configuration
is an array, it should be[configuration[0], configuration.slice(1)]
to capture the rule arguments as an array.