-
Notifications
You must be signed in to change notification settings - Fork 101
[Feature] Add jsdoc-format converter #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JoshuaKGoldberg
merged 5 commits into
typescript-eslint:master
from
KingDarBoja:feature/jsdoc-format-converter
Mar 28, 2020
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
fb4777d
Add jsdoc-format converter
e5c8be0
Merge branch 'master' into feature/jsdoc-format-converter
KingDarBoja c58a457
Replace jsdoc format rule with check indentation
KingDarBoja aecdd1d
Add notice for multiline comments in jsdoc rule
KingDarBoja 98512af
Provide jsdoc format notice closer to TSLint docs
KingDarBoja File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
import { RuleConverter, ConvertedRuleChanges } from "../converter"; | ||
|
||
export const JSDocNoticeMsg = | ||
"ESLint does not support enforcing the first line of multiline JSDoc comments be empty."; | ||
|
||
export const convertJSDocFormat: RuleConverter = () => { | ||
const ruleNames = [ | ||
"jsdoc/check-alignment", | ||
"jsdoc/check-indentation", | ||
"jsdoc/newline-after-description", | ||
]; | ||
|
||
const mappedRuleNames: ConvertedRuleChanges[] = ruleNames.map(ruleName => { | ||
return { ruleName }; | ||
}); | ||
|
||
return { | ||
rules: [...mappedRuleNames], | ||
notices: [JSDocNoticeMsg], | ||
plugins: ["eslint-plugin-jsdoc"], | ||
}; | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
import { convertJSDocFormat, JSDocNoticeMsg } from "../jsdoc-format"; | ||
|
||
describe(convertJSDocFormat, () => { | ||
test("conversion without arguments", () => { | ||
const result = convertJSDocFormat({ | ||
ruleArguments: [], | ||
}); | ||
|
||
expect(result).toEqual({ | ||
rules: [ | ||
{ | ||
ruleName: "jsdoc/check-alignment", | ||
}, | ||
{ | ||
ruleName: "jsdoc/check-indentation", | ||
}, | ||
{ | ||
ruleName: "jsdoc/newline-after-description", | ||
}, | ||
], | ||
notices: [JSDocNoticeMsg], | ||
plugins: ["eslint-plugin-jsdoc"], | ||
}); | ||
}); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.