Merge branch 'master' into unwrap-substitutes-post-simplification

Author: weswigham

.dockerignore

@@ -29,6 +29,7 @@ scripts/processDiagnosticMessages.js
 scripts/produceLKG.js
 scripts/importDefinitelyTypedTests/importDefinitelyTypedTests.js
 scripts/generateLocalizedDiagnosticMessages.js
+scripts/configureLanguageServiceBuild.js
 scripts/*.js.map
 scripts/typings/
 coverage/
@@ -45,4 +46,4 @@ TEST-results.xml
 package-lock.json
 tests
 .vscode
-.git
+.git

.eslintrc.json

@@ -26,6 +26,10 @@
         "@typescript-eslint/no-inferrable-types": "error",
         "@typescript-eslint/no-misused-new": "error",
         "@typescript-eslint/no-this-alias": "error",
+
+        "no-unused-expressions": "off",
+        "@typescript-eslint/no-unused-expressions": ["error", { "allowTernary": true }],
+
         "@typescript-eslint/prefer-for-of": "error",
         "@typescript-eslint/prefer-function-type": "error",
         "@typescript-eslint/prefer-namespace-keyword": "error",
@@ -36,6 +40,13 @@
         "semi": "off",
         "@typescript-eslint/semi": "error",
 
+        "space-before-function-paren": "off",
+        "@typescript-eslint/space-before-function-paren": ["error", {
+            "asyncArrow": "always",
+            "anonymous": "always",
+            "named": "never"
+        }],
+
         "@typescript-eslint/triple-slash-reference": "error",
         "@typescript-eslint/type-annotation-spacing": "error",
         "@typescript-eslint/unified-signatures": "error",
@@ -54,6 +65,7 @@
         "simple-indent": "error",
         "debug-assert": "error",
         "no-keywords": "error",
+        "one-namespace-per-file": "error",
 
         // eslint-plugin-import
         "import/no-extraneous-dependencies": ["error", { "optionalDependencies": false }],
@@ -96,7 +108,6 @@
         "no-trailing-spaces": "error",
         "no-undef-init": "error",
         "no-unsafe-finally": "error",
-        "no-unused-expressions": ["error", { "allowTernary": true }],
         "no-unused-labels": "error",
         "no-var": "error",
         "object-shorthand": "error",

.github/ISSUE_TEMPLATE/Bug_report.md

@@ -1,37 +1,44 @@
----
-name: Bug report
-about: Create a report to help us improve
-
----
-
-<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
-
-Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
-
-Please help us by doing the following steps before logging an issue:
-  * Search: https://github.com/Microsoft/TypeScript/search?type=Issues
-  * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
-
-Please fill in the *entire* template below.
--->
-
-<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
-**TypeScript Version:**  3.4.0-dev.201xxxxx
-
-<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
-**Search Terms:**
-
-**Code**
-
-```ts
-// A *self-contained* demonstration of the problem follows...
-// Test this by running `tsc` on the command-line, rather than through another build tool such as Gulp, Webpack, etc.
-```
-
-**Expected behavior:**
-
-**Actual behavior:**
-
-**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
-
-**Related Issues:** <!-- Did you find other bugs that looked similar? -->
+---
+name: Bug
+about: Create a report to help us improve TypeScript
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
+
+Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
+
+Please help us by doing the following steps before logging an issue:
+  * Search: https://github.com/Microsoft/TypeScript/search?type=Issues
+  * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
+
+Please fill in the *entire* template below.
+-->
+
+<!--
+Please try to reproduce the issue with the latest published version. It may have already been fixed.
+For npm: `typescript@next`
+This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
+-->
+**TypeScript Version:**  3.7.x-dev.201xxxxx
+
+<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
+**Search Terms:**
+
+**Code**
+
+```ts
+// A *self-contained* demonstration of the problem follows...
+// Test this by running `tsc` on the command-line, rather than through another build tool such as Gulp, Webpack, etc.
+```
+
+**Expected behavior:**
+
+**Actual behavior:**
+
+**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
+
+**Related Issues:** <!-- Did you find other bugs that looked similar? -->

.github/ISSUE_TEMPLATE/Feature_request.md

@@ -1,45 +1,47 @@
----
-name: Feature request
-about: Suggest an idea for this project
-
----
-
-<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
-
-Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker.
-
-Please help us by doing the following steps before logging an issue:
-  * Search: https://github.com/Microsoft/TypeScript/search?type=Issues
-  * Read the FAQ, especially the "Common Feature Requests" section: https://github.com/Microsoft/TypeScript/wiki/FAQ
-
--->
-
-## Search Terms
-
-<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->
-
-## Suggestion
-
-<!-- A summary of what you'd like to see added or changed -->
-
-## Use Cases
-
-<!--
-What do you want to use this for?
-What shortcomings exist with current approaches?
--->
-
-## Examples
-
-<!-- Show how this would be used and what the behavior would be -->
-
-## Checklist
-
-My suggestion meets these guidelines:
-
-* [ ] This wouldn't be a breaking change in existing TypeScript/JavaScript code
-* [ ] This wouldn't change the runtime behavior of existing JavaScript code
-* [ ] This could be implemented without emitting different JS based on the types of the expressions
-* [ ] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
-* [ ] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
-
+---
+name: Feature Request
+about: Suggest an idea
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
+
+Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker.
+
+Please help us by doing the following steps before logging an issue:
+  * Search: https://github.com/Microsoft/TypeScript/search?type=Issues
+  * Read the FAQ, especially the "Common Feature Requests" section: https://github.com/Microsoft/TypeScript/wiki/FAQ
+
+-->
+
+## Search Terms
+
+<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->
+
+## Suggestion
+
+<!-- A summary of what you'd like to see added or changed -->
+
+## Use Cases
+
+<!--
+What do you want to use this for?
+What shortcomings exist with current approaches?
+-->
+
+## Examples
+
+<!-- Show how this would be used and what the behavior would be -->
+
+## Checklist
+
+My suggestion meets these guidelines:
+
+* [ ] This wouldn't be a breaking change in existing TypeScript/JavaScript code
+* [ ] This wouldn't change the runtime behavior of existing JavaScript code
+* [ ] This could be implemented without emitting different JS based on the types of the expressions
+* [ ] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
+* [ ] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).

.github/ISSUE_TEMPLATE/Question.md

@@ -0,0 +1,19 @@
+--- 
+blank_issues_enabled: false
+contact_links: 
+  - 
+    about: "Please ask and answer usage questions on Stack Overflow."
+    name: Question
+    url: "https://stackoverflow.com/questions/tagged/typescript"
+  - 
+    about: "Alternatively, you can use the TypeScript Community Discord."
+    name: Chat
+    url: "https://discord.gg/typescript"
+  - 
+    about: "Please check the FAQ before filing new issues"
+    name: "TypeScript FAQ"
+    url: "https://github.com/microsoft/TypeScript/wiki/FAQ"
+  - 
+    about: "Please raise issues about the site on it's own repo."
+    name: Website
+    url: "https://github.com/microsoft/TypeScript-Website/issues/new"

.github/ISSUE_TEMPLATE/config.yml

@@ -0,0 +1,8 @@
+sandersn
+elibarzilay
+weswigham
+andrewbranch
+RyanCavanaugh
+sheetalkamat
+orta
+rbuckton

.github/pr_owners.txt

@@ -0,0 +1,37 @@
+name: CI
+
+on:
+  push:
+    branches:
+      - master
+      - release-*
+  pull_request:
+    branches:
+      - master
+      - release-*
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        node-version: [8.x, 10.x, 12.x]
+
+    steps:
+    - uses: actions/checkout@v1
+      with:
+        fetch-depth: 5
+    - name: Use node version ${{ matrix.node-version }}
+      uses: actions/setup-node@v1
+      with:
+        node-version: ${{ matrix.node-version }}
+    - name: Remove existing TypeScript
+      run: |
+        npm uninstall typescript --no-save
+        npm uninstall tslint --no-save
+    - name: npm install and test
+      run: |
+        npm install
+        npm update
+        npm test

.github/workflows/ci.yml

@@ -45,6 +45,7 @@ scripts/buildProtocol.js
 scripts/ior.js
 scripts/authors.js
 scripts/configurePrerelease.js
+scripts/configureLanguageServiceBuild.js
 scripts/open-user-pr.js
 scripts/open-cherry-pick-pr.js
 scripts/processDiagnosticMessages.d.ts
@@ -59,9 +60,10 @@ internal/
 **/.DS_Store
 .settings
 **/.vs
-**/.vscode
+**/.vscode/*
 !**/.vscode/tasks.json
-!**/.vscode/settings.json
+!**/.vscode/settings.template.json
+!**/.vscode/launch.template.json
 !**/.vscode/extensions.json
 !tests/cases/projects/projectOption/**/node_modules
 !tests/cases/projects/NodeModulesSearch/**/*
@@ -88,7 +90,9 @@ tests/cases/user/TypeScript-React-Native-Starter/TypeScript-React-Native-Starter
 tests/cases/user/TypeScript-Vue-Starter/TypeScript-Vue-Starter
 tests/cases/user/TypeScript-WeChat-Starter/TypeScript-WeChat-Starter
 tests/cases/user/create-react-app/create-react-app
+tests/cases/user/fp-ts/fp-ts
 tests/cases/user/webpack/webpack
 tests/cases/user/puppeteer/puppeteer
 tests/cases/user/axios-src/axios-src
-tests/cases/user/prettier/prettier
+tests/cases/user/prettier/prettier
+.eslintcache

.gitignore

@@ -31,4 +31,8 @@ yarn.lock
 CONTRIBUTING.md
 TEST-results.xml
 .dockerignore
-Dockerfile
+Dockerfile
+.DS_Store
+.eslintrc.json
+.yarnrc
+tmp

.npmignore

@@ -1,6 +1,7 @@
 {
     "recommendations": [
-        "dbaeumer.vscode-eslint"
+        "dbaeumer.vscode-eslint",
+        "rbuckton.tsserver-live-reload"
     ],
 
     "unwantedRecommendations": [