Skip to content

Commit 2d1af77

Browse files
committed
Address CR feedback
1 parent 7362545 commit 2d1af77

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/compiler/binder.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
12
/* @internal */
23
namespace ts {
34
export const enum ModuleInstanceState {
@@ -953,7 +954,7 @@ namespace ts {
953954
}
954955
if ((expression.kind === SyntaxKind.TrueKeyword && flags & FlowFlags.FalseCondition ||
955956
expression.kind === SyntaxKind.FalseKeyword && flags & FlowFlags.TrueCondition) &&
956-
!isExpressionOfOptionalChainRoot(expression) && !isQuestionQuestionExpression(expression.parent)) {
957+
!isExpressionOfOptionalChainRoot(expression) && !isNullishCoalesce(expression.parent)) {
957958
return unreachableFlow;
958959
}
959960
if (!isNarrowingExpression(expression)) {

src/compiler/utilities.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5953,7 +5953,7 @@ namespace ts {
59535953
return isOptionalChainRoot(node.parent) && node.parent.expression === node;
59545954
}
59555955

5956-
export function isQuestionQuestionExpression(node: Node) {
5956+
export function isNullishCoalesce(node: Node) {
59575957
return node.kind === SyntaxKind.BinaryExpression && (<BinaryExpression>node).operatorToken.kind === SyntaxKind.QuestionQuestionToken;
59585958
}
59595959

0 commit comments

Comments
 (0)