Manually remove some deprecations (microsoft#1837)

saschanaz · web-flow · commit 575c5d757867 · 2024-11-02T20:57:03.000Z
Co-authored-by: saschanaz &lt;saschanaz@users.noreply.github.com&gt;
diff --git a/baselines/dom.generated.d.ts b/baselines/dom.generated.d.ts
@@ -5255,11 +5255,7 @@ interface CSSStyleDeclaration {
      * [MDN Reference](https://developer.mozilla.org/docs/Web/CSS/justify-content)
      */
     webkitJustifyContent: string;
-    /**
-     * @deprecated This is a legacy alias of `lineClamp`.
-     *
-     * [MDN Reference](https://developer.mozilla.org/docs/Web/CSS/-webkit-line-clamp)
-     */
+    /** [MDN Reference](https://developer.mozilla.org/docs/Web/CSS/-webkit-line-clamp) */
     webkitLineClamp: string;
     /**
      * @deprecated This is a legacy alias of `mask`.
@@ -26531,17 +26527,9 @@ interface Window extends EventTarget, AnimationFrameProvider, GlobalEventHandler
     readonly outerHeight: number;
     /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/outerWidth) */
     readonly outerWidth: number;
-    /**
-     * @deprecated This is a legacy alias of `scrollX`.
-     *
-     * [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/scrollX)
-     */
+    /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/scrollX) */
     readonly pageXOffset: number;
-    /**
-     * @deprecated This is a legacy alias of `scrollY`.
-     *
-     * [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/scrollY)
-     */
+    /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/scrollY) */
     readonly pageYOffset: number;
     /**
      * Refers to either the parent WindowProxy, or itself.
@@ -28174,17 +28162,9 @@ declare var orientation: number;
 declare var outerHeight: number;
 /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/outerWidth) */
 declare var outerWidth: number;
-/**
- * @deprecated This is a legacy alias of `scrollX`.
- *
- * [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/scrollX)
- */
+/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/scrollX) */
 declare var pageXOffset: number;
-/**
- * @deprecated This is a legacy alias of `scrollY`.
- *
- * [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/scrollY)
- */
+/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/scrollY) */
 declare var pageYOffset: number;
 /**
  * Refers to either the parent WindowProxy, or itself.
diff --git a/baselines/ts5.5/dom.generated.d.ts b/baselines/ts5.5/dom.generated.d.ts
@@ -5255,11 +5255,7 @@ interface CSSStyleDeclaration {
      * [MDN Reference](https://developer.mozilla.org/docs/Web/CSS/justify-content)
      */
     webkitJustifyContent: string;
-    /**
-     * @deprecated This is a legacy alias of `lineClamp`.
-     *
-     * [MDN Reference](https://developer.mozilla.org/docs/Web/CSS/-webkit-line-clamp)
-     */
+    /** [MDN Reference](https://developer.mozilla.org/docs/Web/CSS/-webkit-line-clamp) */
     webkitLineClamp: string;
     /**
      * @deprecated This is a legacy alias of `mask`.
@@ -26531,17 +26527,9 @@ interface Window extends EventTarget, AnimationFrameProvider, GlobalEventHandler
     readonly outerHeight: number;
     /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/outerWidth) */
     readonly outerWidth: number;
-    /**
-     * @deprecated This is a legacy alias of `scrollX`.
-     *
-     * [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/scrollX)
-     */
+    /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/scrollX) */
     readonly pageXOffset: number;
-    /**
-     * @deprecated This is a legacy alias of `scrollY`.
-     *
-     * [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/scrollY)
-     */
+    /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/scrollY) */
     readonly pageYOffset: number;
     /**
      * Refers to either the parent WindowProxy, or itself.
@@ -28174,17 +28162,9 @@ declare var orientation: number;
 declare var outerHeight: number;
 /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/outerWidth) */
 declare var outerWidth: number;
-/**
- * @deprecated This is a legacy alias of `scrollX`.
- *
- * [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/scrollX)
- */
+/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/scrollX) */
 declare var pageXOffset: number;
-/**
- * @deprecated This is a legacy alias of `scrollY`.
- *
- * [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/scrollY)
- */
+/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/scrollY) */
 declare var pageYOffset: number;
 /**
  * Refers to either the parent WindowProxy, or itself.
diff --git a/inputfiles/overridingTypes.jsonc b/inputfiles/overridingTypes.jsonc
@@ -610,7 +610,18 @@
                         "window": {
                             "overrideType": "Window & typeof globalThis"
                         },
+                        "pageXOffset": {
+                            // While this is indeed an alias of scrollX, it's not a vendor prefixed legacy as aliases usually are.
+                            "deprecated": false
+                        },
+                        "pageYOffset": {
+                            // While this is indeed an alias of scrollY, it's not a vendor prefixed legacy as aliases usually are.
+                            "deprecated": false
+                        },
                         "parent": {
+                            // This is technically nullable, but it only happens in some edge cases, and
+                            // making it nullable breaks compatibility as it has historically been non-nullable in TS lib.
+                            // See the example in https://html.spec.whatwg.org/multipage/nav-history-apis.html#dom-parent.
                             "nullable": false
                         }
                     }
@@ -3365,6 +3376,10 @@
                             "name": "cssFloat",
                             "type": "CSSOMString",
                             "mdnUrl": "https://developer.mozilla.org/docs/Web/API/CSSStyleDeclaration/cssFloat"
+                        },
+                        "webkitLineClamp": {
+                            // The corresponding standardized property is not supported by anyone as of 2024-10.
+                            "deprecated": false
                         }
                     }
                 }

Original file line number	Diff line number	Diff line change
`@@ -610,7 +610,18 @@`
`610`	`610`	`"window": {`
`611`	`611`	`"overrideType": "Window & typeof globalThis"`
`612`	`612`	`},`
	`613`	`+ "pageXOffset": {`
	`614`	`+ // While this is indeed an alias of scrollX, it's not a vendor prefixed legacy as aliases usually are.`
	`615`	`+ "deprecated": false`
	`616`	`+ },`
	`617`	`+ "pageYOffset": {`
	`618`	`+ // While this is indeed an alias of scrollY, it's not a vendor prefixed legacy as aliases usually are.`
	`619`	`+ "deprecated": false`
	`620`	`+ },`
`613`	`621`	`"parent": {`
	`622`	`+ // This is technically nullable, but it only happens in some edge cases, and`
	`623`	`+ // making it nullable breaks compatibility as it has historically been non-nullable in TS lib.`
	`624`	`+ // See the example in https://html.spec.whatwg.org/multipage/nav-history-apis.html#dom-parent.`
`614`	`625`	`"nullable": false`
`615`	`626`	`}`
`616`	`627`	`}`
`@@ -3365,6 +3376,10 @@`
`3365`	`3376`	`"name": "cssFloat",`
`3366`	`3377`	`"type": "CSSOMString",`
`3367`	`3378`	`"mdnUrl": "https://developer.mozilla.org/docs/Web/API/CSSStyleDeclaration/cssFloat"`
	`3379`	`+ },`
	`3380`	`+ "webkitLineClamp": {`
	`3381`	`+ // The corresponding standardized property is not supported by anyone as of 2024-10.`
	`3382`	`+ "deprecated": false`
`3368`	`3383`	`}`
`3369`	`3384`	`}`
`3370`	`3385`	`}`