feat(sequelize.d.ts) add operatorsAliases constructor option#140
feat(sequelize.d.ts) add operatorsAliases constructor option#140modulitos wants to merge 1 commit intotypes:masterfrom
Conversation
| * | ||
| * Defaults to true | ||
| */ | ||
| operatorsAliases?: boolean | object; |
There was a problem hiding this comment.
Please use a more precise type than object, e.g. an index signature or an interface.
There was a problem hiding this comment.
It seems that creating an interface here would require porting the OperatorAliases into an Typescipt interface, then referencing that interface in our sequelize.d.ts file. Does that seem like a reasonable approach? Here are the operator aliases from the Sequelize source code: https://github.com/sequelize/sequelize/blob/master/lib/operators.js
I was hoping this would have already been done in the other Sequelize type definitions, but I can't seem to find it here: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/sequelize/v3/index.d.ts I'm happy to implement this port when I have some time.
There was a problem hiding this comment.
They are all here:
Line 100 in ff21415
Should be possible to use a mapped type.
DefinitelyTyped has nothing to do with this repo.
1584b90 to
b451122
Compare
Resolves #139