Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: local development with oracle #7881

Merged
merged 1 commit into from
Nov 9, 2021
Merged

build: local development with oracle #7881

merged 1 commit into from
Nov 9, 2021

Conversation

satanTime
Copy link
Contributor

Description of change

An easy way to run unit tests for Oracle XE locally

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@satanTime
Copy link
Contributor Author

Hi @imnotjames,

I hope this finds you well.

this is an independent PR regarding local testing with Oracle XE which was original implemented in #5685.

Looking forward for your review.
Thank you in advance!

@pleerock pleerock merged commit 4aaafdf into typeorm:master Nov 9, 2021
@pleerock
Copy link
Member

pleerock commented Nov 9, 2021

Looks good to me. Thank you for contribution!

HeartPattern pushed a commit to HeartPattern/typeorm that referenced this pull request Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants