Add support for unix domain sockets (and peer authentication) #1192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried adding a test in c521068 but it fails on Mac w/ Colima due to permissions issues. The new container fails to start with this error: Tried various things (e.g. changing fstype used by Colima, symlink nonsense, etc) without luck. |
mpilquist
commented
Apr 5, 2025
| @@ -16,8 +16,7 @@ ThisBuild / developers := List( | |||
| ThisBuild / tlCiReleaseBranches += "series/0.6.x" | |||
| ThisBuild / tlCiScalafmtCheck := false | |||
| ThisBuild / tlSitePublishBranch := Some("series/0.6.x") | |||
| ThisBuild / githubWorkflowOSes := Seq("ubuntu-latest") | |||
There was a problem hiding this comment.
Don't need this (anymore?)
mpilquist
commented
Apr 5, 2025
| Tests.Argument(TestFrameworks.MUnit, "--exclude-tags=" + excludedTags.mkString(",")) | ||
| else Tests.Argument() | ||
| }, | ||
| Test / baseDirectory := (ThisBuild / Test / run / baseDirectory).value |
There was a problem hiding this comment.
Make forked tests working directory be root of build instead of root of submodule
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1192 +/- ##
==========================================
- Coverage 83.94% 83.24% -0.70%
==========================================
Files 138 140 +2
Lines 2136 2238 +102
Branches 243 230 -13
==========================================
+ Hits 1793 1863 +70
- Misses 343 375 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for connecting to the Postgres server via unix domain sockets.
Example usage:
The above configuration results in connecting via
/tmp/.s.PGSQL.5432. Variations ofwithUnixSocketsare supplied for customizing the path.Supports both trust and peer authentication types.
TODO: Figure out how to test this with the current docker-compose based configuration