Changed io.file.pulls API to return cancellable file handles #811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regarding the |
Contributor
|
@mpilquist my first thought is that TCP sockets have 3 methods in this area (endOfInput, endOfOutput, close), unlike file that has only close. I think we can keep endOfXX like they are and remove close in favor of this pattern. Generally I don't see any reason to manually invoke close, as there is nothing you can do with socket after being closed. |
Member
Author
|
@pchlupacek Agreed on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #772.
If we're good with this overall approach, TCP/UDP sockets should get a similar treatment. Specifically, we should not expose a
closemethod onFileHandle/Socket/etc. and instead, return aCancellable[F,Resource]from pulls.