fix: ensure Topic#publish1 returns accurate result during concurrent closure#3665
Open
guptapratykshh wants to merge 4 commits intotypelevel:mainfrom
Open
fix: ensure Topic#publish1 returns accurate result during concurrent closure#3665guptapratykshh wants to merge 4 commits intotypelevel:mainfrom
guptapratykshh wants to merge 4 commits intotypelevel:mainfrom
Conversation
Contributor
Author
|
@mpilquist can you have a look at this PR , Thanks. |
Member
|
Need to rebase this PR now that other PRs have been merged. Also, need to remove the |
guptapratykshh
force-pushed
the
fix/issue-3644-topic-publish-race
branch
2 times, most recently
from
da8bc03 to
bd2981e
Compare
guptapratykshh
force-pushed
the
fix/issue-3644-topic-publish-race
branch
from
bd2981e to
a30644f
Compare
Member
|
@TomasMikula Mind reviewing this PR? Thanks! |
Contributor
|
So this PR guarantees that
whereas the failing test also requires that
I admit the test is somewhat strict, and I'd consider the implemented behavior acceptable if clearly documented that return value |
TomasMikula
reviewed
Jan 30, 2026
| } | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Minor thing: I think constructing the effect in a right-associative way will lead to slightly faster execution for an IO-like F.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr ensures Topic#publish1 accurately returns Left(Closed) when delivery fails due to concurrent topic closure by checking individual subscriber channel results and also guarantees that Right(()) response from publish1 consistently signifies successful delivery to all currently registered subscribers.
Resolves #3644