Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add filterNot to FunctorFilter #3158

Conversation

gagandeepkalra
Copy link
Contributor

resolves #3022

@codecov-io
Copy link

codecov-io commented Nov 18, 2019

Codecov Report

Merging #3158 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3158      +/-   ##
=========================================
- Coverage   93.04%     93%   -0.04%     
=========================================
  Files         376     376              
  Lines        7374    7395      +21     
  Branches      209     200       -9     
=========================================
+ Hits         6861    6878      +17     
- Misses        513     517       +4
Flag Coverage Δ
#scala_version_212 93.33% <100%> (-0.04%) ⬇️
#scala_version_213 90.61% <100%> (-0.01%) ⬇️
Impacted Files Coverage Δ
...cala/cats/laws/discipline/FunctorFilterTests.scala 100% <100%> (ø) ⬆️
core/src/main/scala/cats/data/Nested.scala 95.18% <100%> (+0.05%) ⬆️
...src/main/scala-2.13+/cats/instances/lazyList.scala 100% <100%> (ø) ⬆️
...s/src/main/scala/cats/laws/FunctorFilterLaws.scala 100% <100%> (ø) ⬆️
core/src/main/scala/cats/data/Chain.scala 98.44% <100%> (ø) ⬆️
core/src/main/scala/cats/instances/queue.scala 100% <100%> (ø) ⬆️
core/src/main/scala/cats/data/Const.scala 100% <100%> (ø) ⬆️
core/src/main/scala/cats/instances/list.scala 100% <100%> (ø) ⬆️
core/src/main/scala/cats/instances/option.scala 98.3% <100%> (+0.02%) ⬆️
core/src/main/scala/cats/instances/map.scala 95.91% <100%> (+0.08%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8867e97...bd9e60b. Read the comment docs.

@takayahilton
Copy link
Contributor

Could you add filterNot to LazyList?

Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gagandeepkalra
Copy link
Contributor Author

Hello, is there something pending before we check this in?

@travisbrown
Copy link
Contributor

Looks good to me!

@travisbrown travisbrown merged commit cc0ba4b into typelevel:master Dec 9, 2019
@travisbrown travisbrown added this to the 2.1.0-RC3 milestone Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add filterNot to FunctorFilter syntax
5 participants