Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 2701 - Ambiguous Eq instances for tuples #3105

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Issue 2701 - Ambiguous Eq instances for tuples #3105

merged 1 commit into from
Oct 16, 2019

Conversation

barambani
Copy link
Contributor

resolves #2701

@codecov-io
Copy link

codecov-io commented Oct 9, 2019 •
edited
Loading

Codecov Report

Merging #3105 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3105   +/-   ##
=======================================
  Coverage   93.52%   93.52%           
=======================================
  Files         368      368           
  Lines        6998     6998           
  Branches      198      198           
=======================================
  Hits         6545     6545           
  Misses        453      453

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e91aa24...842dff7. Read the comment docs.

LukaJCB
LukaJCB approved these changes Oct 16, 2019
View reviewed changes
Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @barambani

@LukaJCB LukaJCB merged commit 6e7ff8f into typelevel:master Oct 16, 2019
@barambani barambani deleted the issue-2701 branch October 16, 2019 21:54
@travisbrown travisbrown added this to the 2.1.0-RC1 milestone Nov 5, 2019
@travisbrown travisbrown added the bug label Nov 6, 2019
@travisbrown travisbrown mentioned this pull request Nov 13, 2019
Closed
22 tasks
travisbrown added a commit to travisbrown/cats that referenced this pull request Nov 19, 2019
@travisbrown
Revert "Changed precedence of tupled instances for Hash and PartialOr…
efd88a0 
…der (typelevel#3105)"

This reverts commit 6e7ff8f.
travisbrown added a commit to travisbrown/cats that referenced this pull request Nov 19, 2019
@travisbrown
Reinstate doc fix from typelevel#3105
23c0466
@travisbrown travisbrown mentioned this pull request Nov 19, 2019
Merged
travisbrown added a commit to travisbrown/cats that referenced this pull request Nov 19, 2019
@travisbrown
Reinstate doc fix from typelevel#3105
d6e940b
rossabaker pushed a commit that referenced this pull request Nov 26, 2019
@travisbrown @rossabaker
Fix broken binary compatibility (#3163)
6697edc 
* Revert "Issue 2891 - Ambiguous Vector instances (#3100)"

This reverts commit e766998.

* Revert "Changed precedence of tupled instances for Hash and PartialOrder (#3105)"

This reverts commit 6e7ff8f.

* Move method back to avoid bincompat breakage

* Reinstate doc fix from #3105
@travisbrown travisbrown mentioned this pull request Nov 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaJCB LukaJCB LukaJCB approved these changes

@kailuowang kailuowang kailuowang approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.1.0-RC1
Development

Successfully merging this pull request may close these issues.

Ambiguous Eq instances for tuples
5 participants
@barambani @codecov-io @kailuowang @LukaJCB @travisbrown