-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a Scala 2.11 branch #3052
Conversation
4148c31
to
91704c4
Compare
Codecov Report
@@ Coverage Diff @@
## scala_2.11 #3052 +/- ##
=============================================
- Coverage 93.46% 93.37% -0.1%
=============================================
Files 368 382 +14
Lines 6979 7155 +176
Branches 184 195 +11
=============================================
+ Hits 6523 6681 +158
- Misses 456 474 +18
Continue to review full report at Codecov.
|
I spent a few minutes going over this the other day, and it seemed fine to me, although I didn't look very closely. The tests pass, so I'd say ship it—it belongs to the unfortunate folks who still have to care about 2.11 now. 😄 |
@LukaJCB, got a minute to review the changes (mainly to the build file)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
Strictly speaking the scala_2.11 branch is already created. This PR strips out Scala 2.12+ related code on this branch.