Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Scala 2.11 branch #3052

Merged
merged 5 commits into from
Sep 17, 2019
Merged

Conversation

kailuowang
Copy link
Contributor

@kailuowang kailuowang commented Sep 10, 2019

Strictly speaking the scala_2.11 branch is already created. This PR strips out Scala 2.12+ related code on this branch.

@kailuowang kailuowang changed the title Make it purely scala 2.11 Create a Scala 2.11 branch Sep 10, 2019
@codecov-io
Copy link

codecov-io commented Sep 11, 2019

Codecov Report

Merging #3052 into scala_2.11 will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           scala_2.11    #3052     +/-   ##
=============================================
- Coverage       93.46%   93.37%   -0.1%     
=============================================
  Files             368      382     +14     
  Lines            6979     7155    +176     
  Branches          184      195     +11     
=============================================
+ Hits             6523     6681    +158     
- Misses            456      474     +18
Impacted Files Coverage Δ
...ain/scala/cats/kernel/compat/TraversableOnce.scala 0% <ø> (ø)
core/src/main/scala/cats/instances/stream.scala 97.22% <ø> (ø)
...tances/ScalaVersionSpecificParallelInstances.scala 90.9% <ø> (ø)
.../src/main/scala/cats/data/OneAndLowPriority4.scala 12.5% <ø> (ø)
...cala/cats/kernel/compat/scalaVersionSpecific.scala 100% <ø> (ø)
...ala/cats/kernel/compat/WrappedMutableMapBase.scala 0% <ø> (ø)
core/src/main/scala/cats/compat/SortedSet.scala 100% <ø> (ø)
...scala/alleycats/compat/IterableEmptyInstance.scala 0% <ø> (ø)
.../scala/cats/data/ScalaVersionSpecificPackage.scala 50% <ø> (ø)
.../cats/kernel/compat/scalaVersionMoreSpecific.scala 100% <ø> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27178ff...cb26621. Read the comment docs.

@travisbrown
Copy link
Contributor

I spent a few minutes going over this the other day, and it seemed fine to me, although I didn't look very closely. The tests pass, so I'd say ship it—it belongs to the unfortunate folks who still have to care about 2.11 now. 😄

@kailuowang
Copy link
Contributor Author

@LukaJCB, got a minute to review the changes (mainly to the build file)?

Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@kailuowang kailuowang merged commit bdc7789 into typelevel:scala_2.11 Sep 17, 2019
@travisbrown travisbrown added this to the 2.1.0-RC1 milestone Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants