Drops Scala 2.11 support on master #3051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaJCB
previously approved these changes
Sep 10, 2019
Codecov Report
@@ Coverage Diff @@
## master #3051 +/- ##
=======================================
Coverage 93.46% 93.46%
=======================================
Files 368 368
Lines 6979 6979
Branches 184 184
=======================================
Hits 6523 6523
Misses 456 456
Continue to review full report at Codecov.
|
kailuowang
requested review from
ChristopherDavenport,
LukaJCB,
alexandru,
djspiewak,
johnynek,
mpilquist,
tpolecat and
travisbrown
Contributor
Author
|
requesting thumbs up from maintainers to drop 2.11 on master. |
Member
|
👍 |
travisbrown
previously approved these changes
Sep 13, 2019
Contributor
travisbrown
left a comment
travisbrown
left a comment
There was a problem hiding this comment.
Two small notes about a test change that seems to be unrelated to the main part? Anyway I'm 100% on board for the main part.
Contributor
Author
|
@LukaJCB , @travisbrown got time to take a look at the commit I added to address feedback? |
Contributor
|
👍 |
travisbrown
approved these changes
Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another PR to add the scala 2.11 branch coming soonPR to add the scala_2.11 branch #3052