Use Foldable foldRight for Traverse and TraverseFilter. - #3015
Merged
Conversation
Contributor
|
Sorry Luka, I didn't mean to request your review, misclicked. |
kailuowang
self-requested a review
August 28, 2019 14:34
travisbrown
self-requested a review
November 6, 2019 09:10
travisbrown
approved these changes
Nov 6, 2019
travisbrown
left a comment
Contributor
There was a problem hiding this comment.
At a glance I was surprised this is stack-safe, but I checked and it seems to be. Looks reasonable to me.
LukaJCB
approved these changes
Nov 6, 2019
22 tasks
gagandeepkalra
added a commit
to gagandeepkalra/cats
that referenced
this pull request
Feb 29, 2020
…al for chain instances
gagandeepkalra
added a commit
to gagandeepkalra/cats
that referenced
this pull request
Feb 29, 2020
…r List to use `foldRight` from Foldable
travisbrown
pushed a commit
that referenced
this pull request
Mar 11, 2020
travisbrown
pushed a commit
that referenced
this pull request
Mar 11, 2020
… use `foldRight` from Foldable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now
After