-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added separateFoldable #2742
Added separateFoldable #2742
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2742 +/- ##
==========================================
+ Coverage 93.28% 93.28% +<.01%
==========================================
Files 376 376
Lines 7323 7328 +5
Branches 174 205 +31
==========================================
+ Hits 6831 6836 +5
Misses 492 492
Continue to review full report at Codecov.
|
Thanks for the contribution. There is ways to get around breaking binary compatibility for this type of addition, but there are quite some hoops to jump through. The good news is in Q2 we are going to allow this type of changes on master with a new branching scheme. So if you can wait, it might be easier to just schedule this to cats 2.1. Otherwise I can guide you on how to avoid breaking BC on Scala 2.11. Let me know. |
@kailuowang I can definitely wait, but I'm OK with jumping through the hoops as well, so I defer to your judgement. |
If you can wait, let's wait to avoid the extra boilerplate code on master. |
@tkroman Do you mind merging master to fix the build? Otherwise looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should drop SeparateFoldableOps
but otherwise looks good to me.
@tkroman Thanks! I think it'll still need merging with master to avoid the 2.11 bincompat check. |
CI failure was Travis nonsense, just restarted that job. |
woohoo, thanks! |
#2741
Since this is a new method, mima is breaking but I haven't used it before, so not sure what to do here.