Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added separateFoldable #2742

Merged
merged 11 commits into from
Nov 14, 2019
Merged

Added separateFoldable #2742

merged 11 commits into from
Nov 14, 2019

Conversation

tkroman
Copy link
Contributor

@tkroman tkroman commented Mar 4, 2019

#2741

Since this is a new method, mima is breaking but I haven't used it before, so not sure what to do here.

@codecov-io
Copy link

codecov-io commented Mar 4, 2019

Codecov Report

Merging #2742 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2742      +/-   ##
==========================================
+ Coverage   93.28%   93.28%   +<.01%     
==========================================
  Files         376      376              
  Lines        7323     7328       +5     
  Branches      174      205      +31     
==========================================
+ Hits         6831     6836       +5     
  Misses        492      492
Flag Coverage Δ
#scala_version_212 93.62% <100%> (ø) ⬆️
#scala_version_213 90.92% <80%> (-0.03%) ⬇️
Impacted Files Coverage Δ
core/src/main/scala/cats/Alternative.scala 92.3% <100%> (+3.41%) ⬆️
core/src/main/scala/cats/syntax/alternative.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffded4b...0f76a76. Read the comment docs.

@kailuowang
Copy link
Contributor

Thanks for the contribution. There is ways to get around breaking binary compatibility for this type of addition, but there are quite some hoops to jump through. The good news is in Q2 we are going to allow this type of changes on master with a new branching scheme. So if you can wait, it might be easier to just schedule this to cats 2.1. Otherwise I can guide you on how to avoid breaking BC on Scala 2.11. Let me know.

@tkroman
Copy link
Contributor Author

tkroman commented Mar 4, 2019

@kailuowang I can definitely wait, but I'm OK with jumping through the hoops as well, so I defer to your judgement.

@kailuowang
Copy link
Contributor

If you can wait, let's wait to avoid the extra boilerplate code on master.

@kailuowang kailuowang added this to the 2.1-RC1 milestone Mar 5, 2019
@travisbrown
Copy link
Contributor

@tkroman Do you mind merging master to fix the build? Otherwise looks good to me.

Copy link
Contributor

@travisbrown travisbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should drop SeparateFoldableOps but otherwise looks good to me.

@travisbrown
Copy link
Contributor

@tkroman Thanks! I think it'll still need merging with master to avoid the 2.11 bincompat check.

@travisbrown
Copy link
Contributor

CI failure was Travis nonsense, just restarted that job.

@travisbrown travisbrown merged commit 4af62d7 into typelevel:master Nov 14, 2019
@tkroman tkroman deleted the separateFoldable branch November 14, 2019 21:55
@tkroman
Copy link
Contributor Author

tkroman commented Nov 14, 2019

woohoo, thanks!

gagandeepkalra added a commit to gagandeepkalra/cats that referenced this pull request Mar 3, 2020
travisbrown pushed a commit that referenced this pull request Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants