Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dual categories. #2217

Merged
merged 1 commit into from
May 30, 2018
Merged

Add dual categories. #2217

merged 1 commit into from
May 30, 2018

Conversation

sellout
Copy link
Contributor

@sellout sellout commented Mar 25, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 26, 2018

Codecov Report

Merging #2217 into master will decrease coverage by <.01%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2217      +/-   ##
==========================================
- Coverage   95.04%   95.03%   -0.01%     
==========================================
  Files         333      334       +1     
  Lines        5789     5799      +10     
  Branches      211      222      +11     
==========================================
+ Hits         5502     5511       +9     
- Misses        287      288       +1
Impacted Files Coverage Δ
...rc/main/scala/cats/laws/discipline/Arbitrary.scala 100% <100%> (ø) ⬆️
core/src/main/scala/cats/data/Op.scala 87.5% <87.5%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f038f0c...20ea11f. Read the comment docs.

@LukaJCB
Copy link
Member

LukaJCB commented Mar 27, 2018

This looks great to me, thanks! One thing to consider is if we want to newtype this instead of wrapping like we did for NonEmptySet and NonEmptyMap?

@kailuowang
Copy link
Contributor

@LukaJCB what do you think? shall we let this one in for Cats 1.2.0, or you think we the newtype is what we must have?

@LukaJCB
Copy link
Member

LukaJCB commented May 30, 2018

No I think this is probably fine to go for now :)

@kailuowang kailuowang merged commit 3993dba into typelevel:master May 30, 2018
@kailuowang kailuowang added this to the 1.2 milestone May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants