-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parallel instance for IorT #2060
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2060 +/- ##
==========================================
- Coverage 94.66% 94.65% -0.02%
==========================================
Files 318 318
Lines 5380 5405 +25
Branches 112 199 +87
==========================================
+ Hits 5093 5116 +23
- Misses 287 289 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really cool, but I think it'd be even better, if we could add an extra instance that uses Parallel on the F
if it exists (this is what I meant yesterday). So something like:
implicit def catsDataParallelForParallelIorT[M[_], F[_], E](implicit P: Parallel[M, F], E: Semigroup[E]) = ...
We can merge it like this though and I could add it later :)
just realized that this one is bin compat, so we can potentially wait after 1.0 but obviously there is no reasons that we have to. |
@LukaJCB shall we merge this for now and add that instance in a followup (if you do merge please change the milestone to 1.0) thanks! |
@LukaJCB -- Got it. I'm adding a higher priority instance that's parallel over the effect as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again!
The same functionality as #2059, but for IorT instead of Ior.