Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parallel instance for IorT #2060

Merged
merged 2 commits into from
Dec 11, 2017
Merged

Conversation

andyscott
Copy link
Contributor

The same functionality as #2059, but for IorT instead of Ior.

@codecov-io
Copy link

codecov-io commented Dec 4, 2017

Codecov Report

Merging #2060 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2060      +/-   ##
==========================================
- Coverage   94.66%   94.65%   -0.02%     
==========================================
  Files         318      318              
  Lines        5380     5405      +25     
  Branches      112      199      +87     
==========================================
+ Hits         5093     5116      +23     
- Misses        287      289       +2
Impacted Files Coverage Δ
core/src/main/scala/cats/data/IorT.scala 97.76% <100%> (+0.34%) ⬆️
...main/scala/cats/kernel/laws/PartialOrderLaws.scala 90.9% <0%> (-9.1%) ⬇️
...c/main/scala/cats/laws/discipline/ArrowTests.scala 100% <0%> (ø) ⬆️
core/src/main/scala/cats/Invariant.scala 95.23% <0%> (ø) ⬆️
laws/src/main/scala/cats/laws/MonadErrorLaws.scala 100% <0%> (ø) ⬆️
core/src/main/scala/cats/instances/function.scala 92.3% <0%> (ø) ⬆️
core/src/main/scala/cats/MonadError.scala 100% <0%> (ø) ⬆️
core/src/main/scala/cats/SemigroupK.scala 100% <0%> (ø) ⬆️
core/src/main/scala/cats/data/Ior.scala 100% <0%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c51fe61...6c3410b. Read the comment docs.

kailuowang
kailuowang previously approved these changes Dec 4, 2017
LukaJCB
LukaJCB previously approved these changes Dec 5, 2017
Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool, but I think it'd be even better, if we could add an extra instance that uses Parallel on the F if it exists (this is what I meant yesterday). So something like:

implicit def catsDataParallelForParallelIorT[M[_], F[_], E](implicit P: Parallel[M, F], E: Semigroup[E]) = ...

We can merge it like this though and I could add it later :)

@kailuowang kailuowang modified the milestones: 1.0.0, 1.1 Dec 5, 2017
@kailuowang
Copy link
Contributor

just realized that this one is bin compat, so we can potentially wait after 1.0 but obviously there is no reasons that we have to.

@kailuowang
Copy link
Contributor

@LukaJCB shall we merge this for now and add that instance in a followup (if you do merge please change the milestone to 1.0) thanks!

@andyscott
Copy link
Contributor Author

andyscott commented Dec 8, 2017

@LukaJCB -- Got it. I'm adding a higher priority instance that's parallel over the effect as well.

@andyscott andyscott dismissed stale reviews from LukaJCB and kailuowang via 6c3410b December 8, 2017 22:03
Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@kailuowang kailuowang merged commit 60d3c12 into typelevel:master Dec 11, 2017
@kailuowang kailuowang modified the milestones: 1.1, 1.0.0 Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants