Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get ready for RC2 #2044

Merged
merged 16 commits into from
Dec 19, 2017
Merged

Get ready for RC2 #2044

merged 16 commits into from
Dec 19, 2017

Conversation

LukaJCB
Copy link
Member

@LukaJCB LukaJCB commented Nov 25, 2017

We're really close to 1.0, so I decided to draft some release notes. I think it'd be great if we could also get a blog post on typelevel.org in time as well. :)

Only have a couple of tickets still open:

And then we have a couple of others that break bincompat so we should think about including them in 1.0.0

@codecov-io
Copy link

codecov-io commented Nov 25, 2017

Codecov Report

Merging #2044 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2044      +/-   ##
==========================================
+ Coverage   94.58%   94.66%   +0.07%     
==========================================
  Files         325      328       +3     
  Lines        5507     5533      +26     
  Branches      220      199      -21     
==========================================
+ Hits         5209     5238      +29     
+ Misses        298      295       -3
Impacted Files Coverage Δ
core/src/main/scala/cats/Invariant.scala 90.47% <0%> (-4.77%) ⬇️
core/src/main/scala/cats/data/IndexedStateT.scala 89.24% <0%> (-0.12%) ⬇️
core/src/main/scala/cats/instances/ordering.scala 100% <0%> (ø) ⬆️
...e/src/main/scala/cats/instances/partialOrder.scala 100% <0%> (ø) ⬆️
core/src/main/scala/cats/data/Const.scala 100% <0%> (ø) ⬆️
core/src/main/scala/cats/Semigroupal.scala 100% <0%> (ø) ⬆️
kernel/src/main/scala/cats/kernel/Eq.scala 93.75% <0%> (ø) ⬆️
core/src/main/scala/cats/instances/invariant.scala 100% <0%> (ø) ⬆️
...ain/scala/cats/laws/InvariantSemigroupalLaws.scala 100% <0%> (ø)
...ts/laws/discipline/InvariantSemigroupalTests.scala 100% <0%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8120890...8ddfed8. Read the comment docs.

Luka Jacobowitz added 2 commits November 25, 2017 18:40
@kailuowang
Copy link
Contributor

Awesome @LukaJCB. I can draft the blog post unless you want to. I am thinking of giving a quick overview how we get here and our commitment to compatibility and community building going forward.

@LukaJCB
Copy link
Member Author

LukaJCB commented Nov 27, 2017

If you draft the blog post, that'd be absolutely great! Im sure we could collaborate to create a really good one!

@kailuowang
Copy link
Contributor

kailuowang commented Nov 27, 2017

great I'll start one tomorrow.

Luka Jacobowitz added 2 commits November 28, 2017 17:45
@kailuowang
Copy link
Contributor

Do you want to also update the AUTHORS.md? Or I'll be happy to do that.

@LukaJCB
Copy link
Member Author

LukaJCB commented Nov 30, 2017

Sure thing, will do! Is there a good way to find out who's a new contributor, or do I have to do it manually? :)

@kailuowang
Copy link
Contributor

I used some scala code to do that one time, and the next time I lost that code so I did manual. Not much difference in terms of time consumed.

@LukaJCB
Copy link
Member Author

LukaJCB commented Nov 30, 2017

Alright then 😁 I've also written up something for the blog post, will you create a PR to the Typelevel blog, or should I do that?

@kailuowang
Copy link
Contributor

kailuowang commented Nov 30, 2017

I am also drafting. I'd say you create a PR here (mark as DO NOT MERGE) before we submit to typelevel blog?
Update: I just created PR with my draft. Let's consolidate there
#2054

@kailuowang
Copy link
Contributor

also are we determined to wait for #2046?

@LukaJCB
Copy link
Member Author

LukaJCB commented Nov 30, 2017

I think we should wait for it, yeah. If needs be, I can get it done on the weekend :)

@kailuowang
Copy link
Contributor

how about #2056, #2057, they are not super essential but I think they are easy and quick to be incorporated. On the other hand we might need to quickly cut the release after them before letting more PRs like these to drag us on.

@LukaJCB
Copy link
Member Author

LukaJCB commented Dec 1, 2017

I'd say we set the deadline for these kinds of PRs for Monday. WDYT? :)

Luka Jacobowitz added 2 commits December 12, 2017 12:12
@LukaJCB LukaJCB changed the title Get ready for 1.0.0 Get ready for RC2 Dec 15, 2017
kailuowang
kailuowang previously approved these changes Dec 19, 2017
Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't have a migration guide, but I think we can wait until 1.0 release.

@LukaJCB LukaJCB merged commit eebcc6d into typelevel:master Dec 19, 2017
LukaJCB pushed a commit that referenced this pull request Dec 19, 2017
* Add grouping to scaladoc for arity methods

This makes it so when you look at the `Applicative` scaladoc you don't
have a bunch of `ap3`, `ap4`, etc noise mixed in with the more
meaningful methods. Instead, the generated higher-arity methods show up
in separate scaladoc groups below.

To see the changes you can pull this branch, run `sbt unidoc` (you may
need to clean first), and open
`cats/docs/target/scala-2.12/unidoc/cats/Applicative.html` in your
browser.

* Add doctest examples for Apply (#2086)

* Get ready for RC2 (#2044)

* Draft release notes

* Update

* Update

* Update

* Update

* Update

* Update Authors

* Update

* Update

* Update

* Update

* update

* Update

* Update CHANGES.md

* Update AUTHORS.md

* Update README.md

* Update deprecations to product{L,R} instead of ap{L,R}
kailuowang added a commit that referenced this pull request Feb 2, 2018
* Setting version to 1.0.0-RC2

* Setting version to 1.0.0-SNAPSHOT

* Update deprecations to product{L,R} instead of ap{L,R} (#2121)

* Add grouping to scaladoc for arity methods

This makes it so when you look at the `Applicative` scaladoc you don't
have a bunch of `ap3`, `ap4`, etc noise mixed in with the more
meaningful methods. Instead, the generated higher-arity methods show up
in separate scaladoc groups below.

To see the changes you can pull this branch, run `sbt unidoc` (you may
need to clean first), and open
`cats/docs/target/scala-2.12/unidoc/cats/Applicative.html` in your
browser.

* Add doctest examples for Apply (#2086)

* Get ready for RC2 (#2044)

* Draft release notes

* Update

* Update

* Update

* Update

* Update

* Update Authors

* Update

* Update

* Update

* Update

* update

* Update

* Update CHANGES.md

* Update AUTHORS.md

* Update README.md

* Update deprecations to product{L,R} instead of ap{L,R}

* Setting version to 1.0.0

* Setting version to 1.0.1-SNAPSHOT

* Setting version to 1.0.1

* Setting version to 1.0.2-SNAPSHOT
@LukaJCB LukaJCB deleted the release-notes branch August 16, 2018 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants