-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
type classes with only defined laws to guideline #1720
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1720 +/- ##
=======================================
Coverage 93.88% 93.88%
=======================================
Files 246 246
Lines 4088 4088
Branches 154 155 +1
=======================================
Hits 3838 3838
Misses 250 250 Continue to review full report at Codecov.
|
@kailuowang thanks for this! Sorry, but I didn't see it until too late, and it has merge conflicts :( |
@ceedubs sorry for the delayed response. Conflicts resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great for clarification! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kailuowang!
This shall fix #334