Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type classes with only defined laws to guideline #1720

Merged
merged 2 commits into from
Jan 8, 2018
Merged

type classes with only defined laws to guideline #1720

merged 2 commits into from
Jan 8, 2018

Conversation

kailuowang
Copy link
Contributor

@kailuowang kailuowang commented Jun 5, 2017

This shall fix #334

@codecov-io
Copy link

codecov-io commented Jun 5, 2017

Codecov Report

Merging #1720 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1720   +/-   ##
=======================================
  Coverage   93.88%   93.88%           
=======================================
  Files         246      246           
  Lines        4088     4088           
  Branches      154      155    +1     
=======================================
  Hits         3838     3838           
  Misses        250      250

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1931c93...b34ea40. Read the comment docs.

@kailuowang
Copy link
Contributor Author

assigning @ceedubs since you thumbed up on #334

@kailuowang kailuowang modified the milestone: 1.0.0-RC1 Aug 8, 2017
@kailuowang kailuowang modified the milestone: 1.0.0-RC1 Aug 29, 2017
@ceedubs
Copy link
Contributor

ceedubs commented Dec 8, 2017

@kailuowang thanks for this! Sorry, but I didn't see it until too late, and it has merge conflicts :(

@kailuowang
Copy link
Contributor Author

@ceedubs sorry for the delayed response. Conflicts resolved

Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great for clarification! :)

Copy link
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kailuowang!

@ceedubs ceedubs merged commit 3774a19 into master Jan 8, 2018
@kailuowang kailuowang deleted the fix-334 branch January 8, 2018 16:51
@kailuowang kailuowang added this to the 1.1 milestone Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typeclasses that ONLY define laws.
4 participants