Rename suspend to defer#1709
Merged
Merged
Conversation
I chose `defer` over `suspend` because both `Free` and `FreeT` have a `Suspend` which is used by `liftF` (not by `suspend`), so this may reduce that confusion as well.
Contributor
|
I like defer over suspend as well (shorter and in my mind clearer). |
Codecov Report
@@ Coverage Diff @@
## master #1709 +/- ##
==========================================
- Coverage 93.96% 93.89% -0.07%
==========================================
Files 241 241
Lines 4091 4094 +3
Branches 160 160
==========================================
Hits 3844 3844
- Misses 247 250 +3
Continue to review full report at Codecov.
|
Contributor
|
👍 on |
26 tasks
djspiewak
approved these changes
May 30, 2017
Contributor
|
merge with three thumbs up; |
peterneyens
changed the title
suspend to defer (or vice versa ??)suspend to defer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I chose
deferoversuspendbecause bothFreeandFreeThave aSuspendwhich is used byliftF(not bysuspend), so this may reduce that confusion as well.This meant replacing three methods though, where
Eval.defer->Eval.suspendwould be only one change. Cats-effect also seems to have chosensuspend(inSync).So this isn't set in stone, I'll happily switch it around if that is what we prefer. Just thought that a PR may help us to decide, since #1635 has been a bit quiet. So, what do we think?