Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Validated.validNel #1658

Merged
merged 2 commits into from
May 13, 2017
Merged

Add Validated.validNel #1658

merged 2 commits into from
May 13, 2017

Conversation

edmundnoble
Copy link
Contributor

Present as a syntax enrichment already.

@codecov-io
Copy link

codecov-io commented May 10, 2017

Codecov Report

Merging #1658 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1658      +/-   ##
==========================================
+ Coverage   93.33%   93.33%   +<.01%     
==========================================
  Files         240      240              
  Lines        3946     3947       +1     
  Branches      136      137       +1     
==========================================
+ Hits         3683     3684       +1     
  Misses        263      263
Impacted Files Coverage Δ
core/src/main/scala/cats/data/Validated.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f98924...a23da34. Read the comment docs.

@ceedubs
Copy link
Contributor

ceedubs commented May 11, 2017

Thanks @edmundnoble. 👍 to this change, but it looks like there are merge conflicts. Also, while this change is trivial, we should probably hit it from a code coverage perspective. Maybe just an sbt-doctest example of using it?

@edmundnoble
Copy link
Contributor Author

Oof. What is in my master branch? I'll add a doctest and fix the conflicts.

@edmundnoble
Copy link
Contributor Author

@ceedubs Should be good now, after CI.

Copy link
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 wonderful thanks @edmundnoble

@ceedubs ceedubs merged commit fc40a1c into typelevel:master May 13, 2017
@kailuowang kailuowang modified the milestone: 1.0.0-MF May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants