added instances of BitSet to allInstances #1592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1592 +/- ##
==========================================
+ Coverage 92.52% 92.52% +<.01%
==========================================
Files 249 250 +1
Lines 3974 3975 +1
Branches 131 138 +7
==========================================
+ Hits 3677 3678 +1
Misses 297 297
Continue to review full report at Codecov.
|
johnynek
reviewed
Apr 7, 2017
| trait BitSetInstances extends cats.kernel.instances.BitSetInstances { | ||
| implicit def catsStdShowForBitSet: Show[BitSet] = new Show[BitSet] { | ||
| def show(fa: BitSet): String = | ||
| fa.toIterator.map(_.show).mkString("BitSet(", ", ", ")") |
There was a problem hiding this comment.
why would we use show here vs fa.toString? There is nothing generic about BitSet and the current implementation is just going to be the same as toString no?
There was a problem hiding this comment.
duh, I wasn't thinking when I mechanically copied from set instances.
|
👍 |
peterneyens
approved these changes
Apr 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1485 , I double checked. I believe that
BitSetis the only missing one.