Bringing back Xor and XorT - fixes #1332 #1333
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Some additional [[Xor]] methods can be found in [[Xor.XorOps XorOps]]. These methods are not defined on [[Xor]] itself because | ||
| * [[Xor]] is covariant in its types `A` and `B`. | ||
| */ | ||
| sealed abstract class Xor[+A, +B] extends Product with Serializable { |
There was a problem hiding this comment.
I would have liked to add a @deprecated annotation here but it causes methods associated with type class instances (down below) to error since they are technically outside of the type.. :/
There was a problem hiding this comment.
You may be able to mark those deprecated as well. IIRC, something that's deprecated can reference other things that are deprecated without warnings. Though maybe I'm making that up. :)
There was a problem hiding this comment.
Ah yes - looks like I have to do this for every single *InstancesN , but it works.
adelbertc
force-pushed
the
bring-back-xor
branch
from
141be65
to
d269531
Compare
|
Oh geez the doctest fails on the |
Current coverage is 91.28% (diff: 91.32%)@@ master #1333 diff @@
==========================================
Files 237 239 +2
Lines 3567 3786 +219
Methods 3502 3714 +212
Messages 0 0
Branches 64 67 +3
==========================================
+ Hits 3260 3456 +196
- Misses 307 330 +23
Partials 0 0
|
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*DO NOT MERGE UNTIL WE GET CONSENUS ON #1332 *