Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MonadError instance for Ior #1544

Closed
leandrob13 opened this issue Feb 27, 2017 · 5 comments
Closed

MonadError instance for Ior #1544

leandrob13 opened this issue Feb 27, 2017 · 5 comments

Comments

@leandrob13
Copy link
Contributor

I noticed there is no MonadError instance for Ior. Is there a reason for this?
@kailuowang
Copy link
Contributor

I think it's just that people didn't get the chance to add it yet. PR is more than welcome!

@leandrob13
Copy link
Contributor Author

@kailuowang got it. I am already working on #1540 and since it is also Ior related I don't know if I should work on it in the same PR or open a new one. What do you suggest?

@kailuowang
Copy link
Contributor

Without any strong preference, I am leaning slightly towards separate PRs.

@leandrob13
Copy link
Contributor Author

@kailuowang got it, I will work on it.

@kailuowang
Copy link
Contributor

Thanks very much @leandrob13

@leandrob13 leandrob13 mentioned this issue Mar 8, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kailuowang @leandrob13