Skip to content
This repository has been archived by the owner on Feb 8, 2022. It is now read-only.

Why don't we move Spire's Module/VectorSpace/MetricSpace/etc. here? #203

Open
ctongfei opened this issue May 12, 2017 · 3 comments
Open

Comments

@ctongfei
Copy link

I think that these typeclasses should go into Algebra.

@johnynek
Copy link
Contributor

I think we could do this. Would you be interested in opening a PR starting at the bottom of that hierarchy?

@ctongfei
Copy link
Author

Thanks :-) I'd be happy to do that.

@denisrosset
Copy link
Contributor

@ctongfei Beware!

I'm currently revising the Spire test suite. The Spire hierarchy has a few inconsistencies; for example, Module pretends to be noncommutative, but actually it is defined in a way that only makes sense for commutative rings. MetricSpace/InnerProductSpace/CoordinateSpace are only valid when the vector spaces are defined on the reals, ...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants