Use pre-commit action #187
Conversation
|
|
||
| - name: Run pre-commit | ||
| run: pre-commit install && pre-commit run --all-files | ||
| - uses: pre-commit/action@v2.0.3 |
There was a problem hiding this comment.
I think it is deprecated 🤔
We can use pre-commitci
There was a problem hiding this comment.
Oh, that's sad news, I'll probably implement it as a reusable workflow in antonagestam/python-build because I really like the idea of everything running within Github Actions (for my own projects that is). I'll close this PR for now.
There was a problem hiding this comment.
See antonagestam/phantom-types#185 that now links to https://github.com/antonagestam/python-build/blob/main/.github/workflows/pre-commit.yaml for reference and let me know if you'd want to use that. I like it for the simplicity and transparency :)
There was a problem hiding this comment.
Yes, looks good! Is it possible to send PRs with fixes back?
There was a problem hiding this comment.
@sobolevn It might be feasible, but I suspect the same limitations would apply as for the action, e.g. this:
while you could technically configure this for a public repository (using a personal access token), I can't think of a way to do this safely without exposing a privileged token to pull requests -- if you have any ideas, please leave an issue!
There was a problem hiding this comment.
Ok, CI is good enough for now! 👍
Thank you!
Attempt to fix pre-commit breaking on master by using the pre-commit action.