Fix paramters for ParallelTestSuite and RemoteTestRunner. #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 tasks
sobolevn
reviewed
Sep 19, 2022
A new parameter `buffer` is added. `suites` is renamed to `subsuites`. ParallelTestSuite: https://github.com/django/django/blob/2fac0a18081dcc77fc860c801e5d727dc90435b3/django/test/runner.py#L468-L475 RemoteTestRunner: https://github.com/django/django/blob/2fac0a18081dcc77fc860c801e5d727dc90435b3/django/test/runner.py#L350 `buffer` was added in django/django@f6713cd, `suites` was renamed in django/django@cb6c197. Both of these changes were made in 4.1rc1. Signed-off-by: Zixuan James Li <p359101898@gmail.com>
Signed-off-by: Zixuan James Li <p359101898@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new parameter
bufferwas added.suiteswas renamed tosubsuites.ParallelTestSuite:
https://github.com/django/django/blob/2fac0a18081dcc77fc860c801e5d727dc90435b3/django/test/runner.py#L468-L475
RemoteTestRunner:
https://github.com/django/django/blob/2fac0a18081dcc77fc860c801e5d727dc90435b3/django/test/runner.py#L350
bufferwas added in django/django@f6713cd,suiteswas renamed in django/django@cb6c197.Both of these changes were made in 4.1rc1.
Signed-off-by: Zixuan James Li p359101898@gmail.com
I have made things!
Related issues