Use temp dir in project for precompile #1153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have not been able to repro either of those test failures locally ¯\_(ツ)_/¯. |
|
Hmmm... maybe related to emberjs/ember.js#18831? I haven't totally digested the solution (or even the problem) there yet, so I'm not sure if it makes sense that we'd be running into that or not. |
dfreeman
approved these changes
May 29, 2020
delete-merged-branch
bot
deleted the
use_temp_dir_in_project_for_precompile
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
ts:precompileto use a temp dir within the project (under cwd) instead of a system temp file. This is to work around microsoft/TypeScript#34749 (comment)It also makes sure the temp dir is removed after the command is run, even if an error is encountered.