update to v2.9.3

- autorelease pools for lower memory footprint
- optimizations for internal structures to avoid objc_msgSend
- no_escape attribute throughout (will avoid warnings on XC 10)
- misc cleanup
- enable parallelized unit tests (XC 10 only)
  - unit tests go from 85s to 62s
  - splitting up TwitterImagePipelineTests will make things
even faster, todo for the future

Author: NSProgrammer

CHANGELOG.md

@@ -1,15 +1,20 @@
-# Twitter Logging Service Change Log
+# Twitter Image Pipeline Change Log
 
 ## Info
 
-**Document version:** 2.9.2
+**Document version:** 2.9.3
 
-**Last updated:** 04/27/2018
+**Last updated:** 05/16/2018
 
 **Author:** Nolan O'Brien
 
 ## History
 
+### 2.9.3
+
+- Add `notifyAllFetchHelpersToRetryFailedLoads` class method to `TIPImageViewFetchHelper`
+  - This will offer an easy way for consuming apps to trigger a reload of failed image fetches when the network conditions change 
+
 ### 2.9.2
 
 - Add `TIPRenderImage` util function

README.md

@@ -360,3 +360,12 @@ Inspecting pipelines is asynchronously done on background threads before the ins
 called on the main thread.  This can provide very useful debugging info.  As an example, Twitter has
 built in UI and tools that use the inspection support of *TIP* for internal builds.
 
+# License
+
+Copyright 2015-2018 Twitter, Inc.
+
+Licensed under the Apache License, Version 2.0: https://www.apache.org/licenses/LICENSE-2.0
+
+# Security Issues?
+
+Please report sensitive security issues via Twitter's bug-bounty program (https://hackerone.com/twitter) rather than GitHub.

TwitterImagePipeline.podspec

@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
   s.name             = 'TwitterImagePipeline'
-  s.version          = '2.9.2'
+  s.version          = '2.9.3'
   s.summary          = 'Twitter Image Pipeline is a robust and performant image loading and caching framework for iOS'
   s.description      = 'Twitter created a framework for image loading/caching in order to fulfill the numerous needs of Twitter for iOS including being fast, safe, modular and versatile.'
   s.homepage         = 'https://github.com/twitter/ios-twitter-logging-service'

TwitterImagePipeline.xcodeproj/xcshareddata/xcschemes/TwitterImagePipeline.xcscheme renamed to TwitterImagePipeline.xcodeproj/xcshareddata/xcschemes/GraphicsRendererSpeed.xcscheme

@@ -3,8 +3,8 @@
    LastUpgradeVersion = "0930"
    version = "1.3">
    <BuildAction
-      parallelizeBuildables = "NO"
-      buildImplicitDependencies = "NO">
+      parallelizeBuildables = "YES"
+      buildImplicitDependencies = "YES">
       <BuildActionEntries>
          <BuildActionEntry
             buildForTesting = "YES"
@@ -14,23 +14,9 @@
             buildForAnalyzing = "YES">
             <BuildableReference
                BuildableIdentifier = "primary"
-               BlueprintIdentifier = "8BFBD3461AA77DB2007A08DD"
-               BuildableName = "libTwitterImagePipeline.a"
-               BlueprintName = "TwitterImagePipeline"
-               ReferencedContainer = "container:TwitterImagePipeline.xcodeproj">
-            </BuildableReference>
-         </BuildActionEntry>
-         <BuildActionEntry
-            buildForTesting = "YES"
-            buildForRunning = "NO"
-            buildForProfiling = "NO"
-            buildForArchiving = "NO"
-            buildForAnalyzing = "NO">
-            <BuildableReference
-               BuildableIdentifier = "primary"
-               BlueprintIdentifier = "8BA975521D77E2C900601D70"
-               BuildableName = "TIPTests.framework"
-               BlueprintName = "TIPTests"
+               BlueprintIdentifier = "8B93D8D220864CAC00CFB01A"
+               BuildableName = "GraphicsRendererSpeed.app"
+               BlueprintName = "GraphicsRendererSpeed"
                ReferencedContainer = "container:TwitterImagePipeline.xcodeproj">
             </BuildableReference>
          </BuildActionEntry>
@@ -42,23 +28,13 @@
       selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
       shouldUseLaunchSchemeArgsEnv = "YES">
       <Testables>
-         <TestableReference
-            skipped = "NO">
-            <BuildableReference
-               BuildableIdentifier = "primary"
-               BlueprintIdentifier = "8BFBD3511AA77DB2007A08DD"
-               BuildableName = "TwitterImagePipelineTests.xctest"
-               BlueprintName = "TwitterImagePipelineTests"
-               ReferencedContainer = "container:TwitterImagePipeline.xcodeproj">
-            </BuildableReference>
-         </TestableReference>
       </Testables>
       <MacroExpansion>
          <BuildableReference
             BuildableIdentifier = "primary"
-            BlueprintIdentifier = "8BFBD3461AA77DB2007A08DD"
-            BuildableName = "libTwitterImagePipeline.a"
-            BlueprintName = "TwitterImagePipeline"
+            BlueprintIdentifier = "8B93D8D220864CAC00CFB01A"
+            BuildableName = "GraphicsRendererSpeed.app"
+            BlueprintName = "GraphicsRendererSpeed"
             ReferencedContainer = "container:TwitterImagePipeline.xcodeproj">
          </BuildableReference>
       </MacroExpansion>
@@ -75,15 +51,16 @@
       debugDocumentVersioning = "YES"
       debugServiceExtension = "internal"
       allowLocationSimulation = "YES">
-      <MacroExpansion>
+      <BuildableProductRunnable
+         runnableDebuggingMode = "0">
          <BuildableReference
             BuildableIdentifier = "primary"
-            BlueprintIdentifier = "8BFBD3461AA77DB2007A08DD"
-            BuildableName = "libTwitterImagePipeline.a"
-            BlueprintName = "TwitterImagePipeline"
+            BlueprintIdentifier = "8B93D8D220864CAC00CFB01A"
+            BuildableName = "GraphicsRendererSpeed.app"
+            BlueprintName = "GraphicsRendererSpeed"
             ReferencedContainer = "container:TwitterImagePipeline.xcodeproj">
          </BuildableReference>
-      </MacroExpansion>
+      </BuildableProductRunnable>
       <AdditionalOptions>
       </AdditionalOptions>
    </LaunchAction>
@@ -93,15 +70,16 @@
       savedToolIdentifier = ""
       useCustomWorkingDirectory = "NO"
       debugDocumentVersioning = "YES">
-      <MacroExpansion>
+      <BuildableProductRunnable
+         runnableDebuggingMode = "0">
          <BuildableReference
             BuildableIdentifier = "primary"
-            BlueprintIdentifier = "8BFBD3461AA77DB2007A08DD"
-            BuildableName = "libTwitterImagePipeline.a"
-            BlueprintName = "TwitterImagePipeline"
+            BlueprintIdentifier = "8B93D8D220864CAC00CFB01A"
+            BuildableName = "GraphicsRendererSpeed.app"
+            BlueprintName = "GraphicsRendererSpeed"
             ReferencedContainer = "container:TwitterImagePipeline.xcodeproj">
          </BuildableReference>
-      </MacroExpansion>
+      </BuildableProductRunnable>
    </ProfileAction>
    <AnalyzeAction
       buildConfiguration = "Debug">

TwitterImagePipeline.xcodeproj/xcshareddata/xcschemes/TwitterImagePipeline.framework.xcscheme

@@ -57,7 +57,8 @@
       shouldUseLaunchSchemeArgsEnv = "YES">
       <Testables>
          <TestableReference
-            skipped = "NO">
+            skipped = "NO"
+            parallelizable = "YES">
             <BuildableReference
                BuildableIdentifier = "primary"
                BlueprintIdentifier = "8BFBD3511AA77DB2007A08DD"

TwitterImagePipeline/Project/NSOperationQueue+TIPSafety.h

@@ -20,10 +20,10 @@ NS_ASSUME_NONNULL_BEGIN
  Same as `[NSOperationQueue addOperation:]` but with added safety.
  If _op_ returns `YES` for `isAsynchronous`, the operation will be retained for a period that
  extends beyond the lifetime of the operation executing to avoid a crash.
+ If called on an OS version that doesn't have the bug, will just pass through to `addOperation:`
  */
 - (void)tip_safeAddOperation:(NSOperation *)op;
 
 @end
 
 NS_ASSUME_NONNULL_END
-

TwitterImagePipeline/Project/TIPImageDownloadInternalContext.h

@@ -14,30 +14,38 @@
 NS_ASSUME_NONNULL_BEGIN
 
 @interface TIPImageDownloadInternalContext : NSObject <TIPImageFetchOperationUnderlyingContext, TIPImageFetchDownloadContext>
+{
+@public
+
+    __unsafe_unretained id<TIPImageFetchDownload> __nullable _download;
+    TIPImageDiskCacheTemporaryFile * __nullable _temporaryFile;
+    TIPPartialImage * __nullable _partialImage;
+    NSString * __nullable _lastModified;
+    NSDictionary<NSString *, id> * __nullable _decoderConfigMap;
+    NSError * __nullable _progressStateError;
+    NSHTTPURLResponse * __nullable _response;
+    NSUInteger _contentLength;
+
+    struct {
+        BOOL didRequestHydration:1;
+        BOOL didStart:1;
+        BOOL didReceiveResponse:1;
+        BOOL responseStatusCodeIsFailure:1;
+        BOOL didReceiveData:1;
+        BOOL didComplete:1;
+    } _flags;
+
+@private
+
+    NSMutableArray<id<TIPImageDownloadDelegate>> * __nonnull _delegates;
+}
 
-@property (nonatomic, assign, nullable) id<TIPImageFetchDownload> download;
+@property (nonatomic, copy, nullable) NSURLRequest *originalRequest;
 @property (nonatomic, copy, nullable) NSURLRequest *hydratedRequest;
 @property (nonatomic, nullable) id<TIPImageFetchDownloadClient> client;
 @property (nonatomic, nullable) dispatch_queue_t downloadQueue;
 
-@property (nonatomic, copy, nullable) NSURLRequest *originalRequest;
-@property (nonatomic, nullable) TIPImageDiskCacheTemporaryFile *temporaryFile;
-@property (nonatomic, nullable) TIPPartialImage *partialImage;
-@property (nonatomic, copy, nullable) NSString *lastModified;
-@property (nonatomic, copy, nullable) NSDictionary<NSString *, id> *decoderConfigMap;
-
-@property (nonatomic, nullable) NSError *progressStateError;
-
-@property (nonatomic) BOOL didRequestHydration;
-@property (nonatomic) BOOL didStart;
-@property (nonatomic) BOOL didReceiveResponse;
-@property (nonatomic) BOOL responseStatusCodeIsFailure;
-@property (nonatomic) BOOL didReceiveData;
-@property (nonatomic) BOOL didComplete;
-
-@property (nonatomic, nullable) NSHTTPURLResponse *response;
-@property (nonatomic) NSUInteger contentLength;
-@property (nonatomic, readonly) NSUInteger delegateCount;
+@property (nonatomic, readonly) NSUInteger delegateCount; // computed property
 
 - (NSOperationQueuePriority)downloadPriority;
 - (nullable id<TIPImageDownloadDelegate>)firstDelegate;

TwitterImagePipeline/Project/TIPImageDownloadInternalContext.m

@@ -15,9 +15,6 @@
 NS_ASSUME_NONNULL_BEGIN
 
 @implementation TIPImageDownloadInternalContext
-{
-    NSMutableArray<id<TIPImageDownloadDelegate>> *_delegates;
-}
 
 - (instancetype)init
 {
@@ -73,15 +70,15 @@ - (void)removeDelegate:(id<TIPImageDownloadDelegate>)delegate
     NSUInteger count = _delegates.count;
     [_delegates removeObject:delegate];
     if (count > _delegates.count) {
-        id<TIPImageFetchDownload> download = self.download;
+        id<TIPImageFetchDownload> download = _download;
         [TIPImageDownloadInternalContext executeDelegate:delegate suspendingQueue:NULL block:^(id<TIPImageDownloadDelegate> blockDelegate) {
             [blockDelegate imageDownload:(id)download didCompleteWithPartialImage:nil lastModified:nil byteSize:0 imageType:nil image:nil imageRenderLatency:0.0 statusCode:0 error:[NSError errorWithDomain:TIPImageFetchErrorDomain code:TIPImageFetchErrorCodeCancelled userInfo:nil]];
         }];
     }
 }
 
 - (void)executePerDelegateSuspendingQueue:(nullable dispatch_queue_t)queue
-                                    block:(void(^)(id<TIPImageDownloadDelegate>))block;
+                                    block:(void(^)(id<TIPImageDownloadDelegate>))block
 {
     for (id<TIPImageDownloadDelegate> delegate in _delegates) {
         [TIPImageDownloadInternalContext executeDelegate:delegate
@@ -91,14 +88,14 @@ - (void)executePerDelegateSuspendingQueue:(nullable dispatch_queue_t)queue
 
 + (void)executeDelegate:(id<TIPImageDownloadDelegate>)delegate
         suspendingQueue:(nullable dispatch_queue_t)queue
-                  block:(void (^)(id<TIPImageDownloadDelegate>))block;
+                  block:(void (^)(id<TIPImageDownloadDelegate>))block
 {
     dispatch_queue_t delegateQueue = [delegate respondsToSelector:@selector(imageDownloadDelegateQueue)] ? delegate.imageDownloadDelegateQueue : NULL;
     if (delegateQueue) {
         if (queue) {
             dispatch_suspend(queue);
         }
-        dispatch_async(delegateQueue, ^{
+        tip_dispatch_async_autoreleasing(delegateQueue, ^{
             block(delegate);
             if (queue) {
                 dispatch_resume(queue);